[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818702640 > That is where we don't agree. I don't see a good use case for that (even if it the current status quo). Can you give one? I'm not sure

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818563923 @kwin, right. So the current behavior is to never reference "content" content packages and never write them. I think we should as a first step

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818516741 @kwin, I don't disagree that it might be a mistake to ignore "content" content packages - however, that is what this option is specifically for

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817736465 @kwin, right, sorry - anyways, I think it makes sense to make the drop content selectable but to write the content package no matter what seems

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817705532 @kwin - I'm not sure we should do this change without providing for an option to not write out the artifact. Could we maybe have that cli