[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447483580 ## File path: src/test/java/org/apache/sling/graphql/core/mocks/URLScalarConverter.java ## @@ -41,4 +41,14 @@ final Stri

[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447126408 ## File path: src/main/java/org/apache/sling/graphql/core/scalars/SlingScalarsProvider.java ## @@ -46,55 +49,17 @@ Constants

[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447483580 ## File path: src/test/java/org/apache/sling/graphql/core/mocks/URLScalarConverter.java ## @@ -41,4 +41,14 @@ final Stri

[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-29 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447126408 ## File path: src/main/java/org/apache/sling/graphql/core/scalars/SlingScalarsProvider.java ## @@ -46,55 +49,17 @@ Constants