[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

kwin commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1188253002 `close()` is the last method called on an instance of try with resources so I fail to see how this would have a negative impact. The CloseShieldWriter uses that to

[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

kwin commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1187888071 > First this does not work as it replaces the writer when closed is called I am not following here. You can just use `try (JsonWriter writer =

[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

kwin commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1186096566 I would suggest using https://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/output/CloseShieldWriter.html#wrap-java.io.Writer- instead. Then