schaefa commented on PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1191830068
Updated the code to use a Wrapper to prevent the closure to satisfy the
SonarCloud code check
--
This is an automated message from the Apache Git Service.
To
schaefa commented on PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1188277883
@kwin You give it a try (on both execute() methods):
try (JsonWriter writer =
Json.createWriter(CloseShieldWriter.wrap(response.getWriter( {
schaefa commented on PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-118804
@kwin The Close Shield Writer is not just preventing the close but it is
replacing the writer:
public void close() {
this.out =
schaefa commented on PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1187841108
@kwin First this does not work as it replaces the writer when closed is
called but I also think that we should make it explicit there as this is
important. Also
