[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-27 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338633803 ## src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-27 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338631696 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -133,24 +124,47 @@ public boolean

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-27 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338631416 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -133,24 +124,47 @@ public boolean

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337173815 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -47,34 +45,28 @@ * use the loginAdministrative method.

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337172793 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -133,24 +124,47 @@ public boolean

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337171961 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -83,23 +75,22 @@ public class LoginAdminAllowList {

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337169650 ## src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329754434 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-06-06 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1219599388 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-06-06 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1219277825 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software