kwin commented on PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1354376709
Due to concerns with regards to backwards-compatibility I propose to add the
new statement `enforce principal ACL` (with same options and enclosing path
privilege st
kwin commented on PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1353038192
If there are no further concerns I am gonna merge tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kwin commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-861569957
Locally the ITs pass for me as well with
```
Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /usr/local/Cellar/maven/3.8.
kwin commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-861532444
There are errors now in the IT:
```[ERROR]
org.apache.sling.jcr.repoinit.it.RepoInitTextIT.namespaceAndCndRegistered Time
elapsed: 11.601 s <<< E
kwin commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-827419313
@bdelacretaz Anything else outstanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kwin commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-816479097
@anchela Thanks for the review, I incorporated your feedback except for the
changes to the exception handling (error code, more specific exception type).
T
kwin commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-815998378
@anchela Thanks for the comment, I changed according to your recommendation
in
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14/commit
