[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on pull request #20: SLING-9781 - [Sling Models] Caching doesn't work with Wrapped requests

2020-10-05 Thread GitBox
cjelger commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/20#issuecomment-703574960 @justinedelson Thank you for the merge. It would be great if you could also release a new version since this issue pretty much prevents caching from

[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on pull request #20: SLING-9781 - [Sling Models] Caching doesn't work with Wrapped requests

2020-10-02 Thread GitBox
cjelger commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/20#issuecomment-702568534 > at least could not say whether it would be expected that for a wrapped resource if the cache should be keyed on the wrapper or the base. I agree

[GitHub] [sling-org-apache-sling-models-impl] cjelger commented on pull request #20: SLING-9781 - [Sling Models] Caching doesn't work with Wrapped requests

2020-10-01 Thread GitBox
cjelger commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/20#issuecomment-702017054 @justinedelson @raducotescu Can you please have a look at the PR? Thanks. This is an