[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

2022-10-24 Thread GitBox
nonanalou commented on code in PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1003046153 ## src/main/java/org/apache/sling/xss/impl/xml/AntiSamyRules.java: ## @@ -125,3 +126,10 @@ public Map getCommonPatternByName() { .col

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

2022-10-20 Thread GitBox
nonanalou commented on code in PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559957 ## src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyWithTestConfigTest.java: ## @@ -0,0 +1,146 @@ +/*

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

2022-10-20 Thread GitBox
nonanalou commented on code in PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559727 ## src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyWithTestConfigTest.java: ## @@ -0,0 +1,146 @@ +/*

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

2022-10-20 Thread GitBox
nonanalou commented on code in PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559047 ## src/main/java/org/apache/sling/xss/impl/AntiSamyPolicyAdapter.java: ## @@ -222,43 +224,28 @@ public boolean apply(String s) { private static P

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

2022-10-20 Thread GitBox
nonanalou commented on code in PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000558760 ## src/main/java/org/apache/sling/xss/impl/AntiSamyPolicyAdapter.java: ## @@ -222,43 +224,28 @@ public boolean apply(String s) { private static P