[GitHub] bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON

bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-425071605 Thanks @simonetripodi I rebased and squashed your commits to make it easier to see the changes.

[GitHub] bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON

bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-425048243 Hi @simonetripodi yes, a change was made to limit includes to a single one. So `Feature#getInclu

[GitHub] bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON

bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-424647156 Hi @simonetripodi I see that your branch now has merge conflicts. Would you be able to rebase so

[GitHub] bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON

bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature to JSON URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-423986784 LGTM, I originally did the opposite as I couldn't get the JsonGenerator to do pretty printing: