Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
stefanseifert merged PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2049560447 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quali

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
stefanseifert commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560922574 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: i've created [SLING-12287](https://issues.apache.or

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
csaboka commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560500748 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: I think this change would be better done in a separate PR,

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
reschke commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560466861 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: These versions of Oak and Jackrabbit are EOLd. Plea

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
csaboka commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2047124607 This change depends on https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 . It won't build properly until that PR is merged. Th

[PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
csaboka opened a new pull request, #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec