Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-12 Thread Robert Munteanu
On Wed, 2024-09-11 at 17:30 +0200, Konrad Windszus wrote: > Restricting to LTS version is fine with me, but please allow non LTS > version in case they are newer than the newest LTS, i.e. Java 22 and > 23. > Certain branches/PRs may want to try new features which didn’t land > in any LTS version ye

Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-11 Thread Konrad Windszus
Restricting to LTS version is fine with me, but please allow non LTS version in case they are newer than the newest LTS, i.e. Java 22 and 23. Certain branches/PRs may want to try new features which didn’t land in any LTS version yet. Thanks, Konrad > On 11. Sep 2024, at 15:12, Robert Munteanu

Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-11 Thread Robert Munteanu
On Sun, 2024-09-08 at 18:08 +0200, Konrad Windszus wrote: > and also the regex (to allow 2x versions): I'll take that as a separate change. But I wonder whether we should allow all 1? and 2? versions or rather the 'LTS' versions 8/11/17/21. Thanks, Robert

Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-11 Thread Robert Munteanu
Thanks all for the comments, created https://issues.apache.org/jira/browse/SLING-12426 . Thanks, Robert On Tue, 2024-09-10 at 13:42 +0200, Julian Sedding wrote: > +1 - I think it makes sense to manage the version in each module's > pom. > > Regards > Julian > > On Sun, 8 Sept 2024 at 18:08, Kon

Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-08 Thread Konrad Windszus
+1 We need to adjust the enforcer rule then with regards to message (to mention that it needs to be set explicitly) and also the regex (to allow 2x versions): https://github.com/apache/sling-parent/blob/0bf3676a221c6beea001bea876ca9e50156f5858/sling-parent/pom.xml#L281-L285 Konrad > On 7. Sep

Re: [RT] Removing the default value for sling.java.version from the parent pom

2024-09-08 Thread Konrad Windszus
+1 We need to adjust the enforcer rule then with regards to message (to mention that it needs to be set explicitly) and also the regex (to allow 2x versions): https://github.com/apache/sling-parent/blob/0bf3676a221c6beea001bea876ca9e50156f5858/sling-parent/pom.xml#L281-L285 Konrad > On 7. Sep