[VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
Hi, On Monday, January 12, 2015, Carsten Ziegeler > wrote: > ...I fixed the sorting problem and reverted back to a plain set in rev 1651168 > Would be great if everyone could give this a try before I cut a new release... Works for me, thanks! All tests pass with Java 1.6, 1.7 and 1.8 > > -Bertra

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
On Mon, Jan 12, 2015 at 4:13 PM, Carsten Ziegeler wrote: > ...Is is really a code bug, I fail to see why?... I haven't spent ages analyzing but nothing looks wrong in the test, and the JcrResourceBundle did not give the correct precedence to /libs over /apps before my revision 1651110 changes. -

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Carsten Ziegeler
Am 12.01.15 um 16:12 schrieb Bertrand Delacretaz: > On Mon, Jan 12, 2015 at 4:09 PM, Carsten Ziegeler > wrote: >> ...I think the test is wrong, the impl shouldn't be required to use an >> ordered set (unless I'm overlooking something) > > I haven't looked at all the details but it seemed lik

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Carsten Ziegeler
Am 12.01.15 um 16:07 schrieb Bertrand Delacretaz: > Hi, > > On Fri, Jan 9, 2015 at 12:22 PM, Carsten Ziegeler > wrote: >> ...we solved two issues >> https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 > > The version there says 2.2.12 but the subject line of this message > says 2

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
On Mon, Jan 12, 2015 at 4:09 PM, Carsten Ziegeler wrote: > ...I think the test is wrong, the impl shouldn't be required to use an > ordered set (unless I'm overlooking something) I haven't looked at all the details but it seemed like the ordering is used to give precedence to messages under /

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Carsten Ziegeler
Am 12.01.15 um 16:03 schrieb Bertrand Delacretaz: > On Mon, Jan 12, 2015 at 3:34 PM, Robert Munteanu wrote: >> ...Without looking at the test, I think it's relying on the ordering >> maintained by a HashSet, which has changed with Java 8, and is of >> course nothing to rely on... > > It's somethi

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
Hi, On Fri, Jan 9, 2015 at 12:22 PM, Carsten Ziegeler wrote: > ...we solved two issues > https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 The version there says 2.2.12 but the subject line of this message says 2.3.0, something's not right. I have now fixed the bug reported by

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
On Mon, Jan 12, 2015 at 3:34 PM, Robert Munteanu wrote: > ...Without looking at the test, I think it's relying on the ordering > maintained by a HashSet, which has changed with Java 8, and is of > course nothing to rely on... It's something like that but in the actual code, not in the test - look

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Robert Munteanu
On Mon, Jan 12, 2015 at 4:32 PM, Bertrand Delacretaz wrote: > On Sun, Jan 11, 2015 at 7:31 PM, Oliver Lietz wrote: >> ...Failed tests: >> JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but >> was:<[K�che]> > > I get the same failure with Java 8, but with Java 7 the test passes.

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Bertrand Delacretaz
On Sun, Jan 11, 2015 at 7:31 PM, Oliver Lietz wrote: > ...Failed tests: > JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but > was:<[K�che]> I get the same failure with Java 8, but with Java 7 the test passes. -Bertrand

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Oliver Lietz
On Monday 12 January 2015 12:34:02 Carsten Ziegeler wrote: > Does latest trunk also fail for you? Yes, fails. O. > Carsten > > Am 11.01.15 um 19:31 schrieb Oliver Lietz: > > On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote: > >> Hi, > >> > >> we solved two issues > >> https://issues.a

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-12 Thread Carsten Ziegeler
Does latest trunk also fail for you? Carsten Am 11.01.15 um 19:31 schrieb Oliver Lietz: > On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote: >> Hi, >> >> we solved two issues >> https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 > > building from tag fails: > > Tests run

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-11 Thread Oliver Lietz
On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote: > Hi, > > we solved two issues > https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 building from tag fails: Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.313 sec <<< FAILURE! - in org.apache.sling.i1

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-09 Thread Antonio Sanso
+1 (verified gpg/md5/sha1) regards antonio On Jan 9, 2015, at 12:22 PM, Carsten Ziegeler wrote: > Hi, > > we solved two issues > https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1163

[VOTE] Release Apache Sling i18n 2.3.0

2015-01-09 Thread Carsten Ziegeler
Hi, we solved two issues https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1163/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/

Re: [VOTE] Release Apache Sling i18n 2.3.0

2015-01-09 Thread Carsten Ziegeler
+1 Carsten Am 09.01.15 um 12:22 schrieb Carsten Ziegeler: > Hi, > > we solved two issues > https://issues.apache.org/jira/browse/SLING/fixforversion/12327960 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1163/ > > You can use this UNIX script to do