Hi,
this thread is about voting for the acceptation of sling pipes donation,
tracked in SLING-5134.
An archive containing the contribution is attached to SLING-5134, shasum
7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on github at [0]
Please cast your votes.
Cheers,
Nicolas
[0]
Hi,
fixed the test issue for both java version (i should say nashorn versions)
thanks to Robert’s patch.
new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1,
please vote
Nicolas
> On 15 Oct 2015, at 14:42, Nicolas Peltier wrote:
>
> yes, closing this thread now, will
On Mon, 2015-10-12 at 13:49 +, Nicolas Peltier wrote:
> Hi,
>
> this thread is about voting for the acceptation of sling pipes
> donation, tracked in SLING-5134.
>
> An archive containing the contribution is attached to SLING-5134,
> shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is vi
out of curiosity, can you tell me which one of the tests failed? (it doesn’t on
mine)
Nicolas
> On 14 Oct 2015, at 14:57, Robert Munteanu wrote:
>
> On Mon, 2015-10-12 at 13:49 +, Nicolas Peltier wrote:
>> Hi,
>>
>> this thread is about voting for the acceptation of sling pipes
>> donation
On Wed, 2015-10-14 at 15:17 +, Nicolas Peltier wrote:
> out of curiosity, can you tell me which one of the tests failed? (it
> doesn’t on mine)
testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time
elapsed: 0.085 sec <<< FAILURE!
java.lang.AssertionError: computed expression hav
Thanks Robert, will fix that and update the ticket then :-)
Nicolas
> On 14 Oct 2015, at 17:23, Robert Munteanu wrote:
>
> On Wed, 2015-10-14 at 15:17 +, Nicolas Peltier wrote:
>> out of curiosity, can you tell me which one of the tests failed? (it
>> doesn’t on mine)
> testAdditionalScript
updated tarball & shasum, with additional bugfix.
for your test issue, which version of java are you running?
> On 14 Oct 2015, at 18:01, Nicolas Peltier wrote:
>
> Thanks Robert, will fix that and update the ticket then :-)
>
> Nicolas
>> On 14 Oct 2015, at 17:23, Robert Munteanu wrote:
>>
re-updated tarball & shasum with Robert’s issue fix.
Please vote now :-)
Nicolas
> On 14 Oct 2015, at 21:26, Nicolas Peltier wrote:
>
> updated tarball & shasum, with additional bugfix.
>
> for your test issue, which version of java are you running?
>
>> On 14 Oct 2015, at 18:01, Nicolas Pe
Hi,
On Thu, Oct 15, 2015 at 1:36 PM, Nicolas Peltier wrote:
>... re-updated tarball & shasum with Robert’s issue fix
I'm still getting the following error running mvn clean install with
java 1.8 on the archive with sha1
68eee1fa87784ea841c80e88b344ec92deb0f848 :
Failed tests:
PipeBindings
:-D (<- me getting nuts)
wild guess is you run java 1.8_0.31, and your computer is at risk ;-), please
update to 1.8_0.60
> On 15 Oct 2015, at 13:58, Bertrand Delacretaz wrote:
>
> Hi,
>
> On Thu, Oct 15, 2015 at 1:36 PM, Nicolas Peltier wrote:
>> ... re-updated tarball & shasum with Robert’s
On Thu, 2015-10-15 at 12:24 +, Nicolas Peltier wrote:
> :-D (<- me getting nuts)
>
> wild guess is you run java 1.8_0.31, and your computer is at risk ;-
> ), please update to 1.8_0.60
How about the following 'fix'?
diff --git a/src/test/java/org/apache/sling/pipes/PipeBindingsTest.java
b/sr
Can we maybe stop this vote thread, resolve the issues and then start a
clean vote thread? Otherwise tracking this is very hard.
Thanks
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org
yes, closing this thread now, will resend a vote once it’s fixed. Sorry about
that.
Nicolas
> On 15 Oct 2015, at 14:34, Carsten Ziegeler wrote:
>
> Can we maybe stop this vote thread, resolve the issues and then start a
> clean vote thread? Otherwise tracking this is very hard.
>
> Thanks
> Ca
bump
> On 17 Oct 2015, at 10:54, Nicolas Peltier wrote:
>
> Hi,
>
> fixed the test issue for both java version (i should say nashorn versions)
> thanks to Robert’s patch.
> new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1,
> please vote
>
> Nicolas
>
>> On 15 Oct
Hi Nicolas,
I've configured my email client to display conversations as a thread as
long as people "answer" to an email and I can imagine that it's the same
for other people as well. To stop this vote thread as Carsten suggested
it would be better to write a new email with a new subject to
de
thx for the tip!
> On 23 Oct 2015, at 15:13, Sandro Boehme wrote:
>
> Hi Nicolas,
>
> I've configured my email client to display conversations as a thread as long
> as people "answer" to an email and I can imagine that it's the same for other
> people as well. To stop this vote thread as Carst
On Wed, 2015-10-14 at 19:26 +, Nicolas Peltier wrote:
> for your test issue, which version of java are you running?
$ mvn -v
Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-
22T14:57:37+03:00)
Maven home: /usr/share/java/maven
Java version: 1.8.0_60, vendor: Oracle Corpo
Thanks Robert, fixed it, and updated the ticket / will update the vote thread.
interesting case: 1.8.0_31’s nashorn returns 3(Integer) for 1+2 when 1.8.0_60
one returns 3L
this said it should just be a pain for the tests, as client code is generally
agnostic of the type.
> On 15 Oct 2015, at 0
18 matches
Mail list logo