[ 
https://issues.apache.org/jira/browse/SLING-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-9982.
-----------------------------

> ConfigurationEntryHandlerTest: doesn't test serviceusermapping with 
> principalname-array
> ---------------------------------------------------------------------------------------
>
>                 Key: SLING-9982
>                 URL: https://issues.apache.org/jira/browse/SLING-9982
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> from what i could see there is no test verify that the recommended 
> service-mapping format is properly converted.
> the expected value is defined as: 
> {code:java}
> "com.adobe.acs.acs-aem-samples-bundle=admin",
> "com.adobe.acs.acs-aem-samples-bundle:sample-service=oauthservice{code}
> the recommended format though is
> {code:java}
> "com.adobe.acs.acs-aem-samples-bundle:simple-sample-service=[principalname1],
> "com.adobe.acs.acs-aem-samples-bundle:aggregated-sample-service=[principalname1,
>  principalname2, principalname3]{code}
> for the sake of completeness i would recommend to make sure both cases are 
> covered with tests.
> also, i would recommend not to use 'admin' as test content. this is the 
> default value for the admin-id in Jackrabbit Oak, which is a regular user and 
> not a service user. if sling-servicemapping is configured with the 
> {{JcrSystemUserValidator}} enabled (like Adobe AEM) regular users and groups 
> won't be allowed to be configured in service user mappings.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to