[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497669#comment-16497669 ]
Nicolas Peltier edited comment on SLING-7692 at 6/1/18 7:28 AM: ---------------------------------------------------------------- {quote}would be better to do such things no a branch first{quote} yeah sorry about that. Do you think --force push on github would be reflected on gitbox? {quote}jcr-mock has support for multiple sessions{quote} isn't this the issue? I mean the problem then is not only refresh(false) should throw unsupported, but refresh(true & false). I guess then it drills down either to support multiple session, and not support refreshes, either not support multiple session, and support refresh(false) (refresh(true) being cool then as a NOP). I'd lean towards the later as i see less cases of multiple session than reverts in a unit test context, but i'll take your word. was (Author: npeltier): {quote}would be better to do such things no a branch first{quote} yeah sorry about that. Do you think --force push on github would be reflected on gitbox? {quote}jcr-mock has support for multiple sessions{quote} isn't this the issue? I mean the problem then is not only refresh(false) should throw unsupported, but refresh(*). I guess then it drills down either to support multiple session, and not support refreshes, either not support multiple session, and support refresh(false) (refresh(true) being cool then as a NOP). I'd lean towards the later as i see less cases of multiple session than reverts in a unit test context, but i'll take your word. > MockSession.revert(false) should be supported > --------------------------------------------- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing > Affects Versions: Testing JCR Mock 1.3.2 > Reporter: Nicolas Peltier > Assignee: Nicolas Peltier > Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)