[ 
https://issues.apache.org/jira/browse/SLING-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356297#comment-17356297
 ] 

Konrad Windszus commented on SLING-10450:
-----------------------------------------

Fixed in 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/163f79552ff35796bb8cb59808ed3026f156b65b.

> ContentPackage2FeatureModelConverter.java should implement Closeable
> --------------------------------------------------------------------
>
>                 Key: SLING-10450
>                 URL: https://issues.apache.org/jira/browse/SLING-10450
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> Forgetting to call {{cleanup}} on the 
> {{ContentPackage2FeatureModelConverter}} leads to big dangling temp folders. 
> To allow semantic code checks detect such failures, the class should 
> implement {{Closeable}} and call {{cleanup}} in its {{close}} method.
> Look at [https://github.com/adobe/aemanalyser-maven-plugin/issues/76] for a 
> concrete issue caused by this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to