[ 
https://issues.apache.org/jira/browse/SLING-10937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449621#comment-17449621
 ] 

Konrad Windszus commented on SLING-10937:
-----------------------------------------

I agree with that proposal. I already refactored the affected test to no longer 
use the equals argument matchers for the resource. That way it still works with 
RESOURCERESOLVER_MOCK.

> Resource in tested Sling Model not equal to Resource it was adapted from 
> (RESOURCERESOLVER_MOCK)
> ------------------------------------------------------------------------------------------------
>
>                 Key: SLING-10937
>                 URL: https://issues.apache.org/jira/browse/SLING-10937
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>    Affects Versions: Testing Sling Mock 3.1.2
>            Reporter: Konrad Windszus
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The resources returned from 
> {{org.apache.sling.testing.mock.sling.RRMockResourceResolverWrapper}} are of 
> type {{ResourceResolverResourceWrapper}} (in case the resource providers are 
> empty).
> When these resources are adapted to a Sling Model, the injected resource is 
> the unwrapped resource which is not equal to the wrapped resource from 
> outside.
> This is due to the fact that {{ResourceResolverResourceWrapper.adaptTo(...)}} 
> is not overwritten but just delegated to the underlying Resource. That makes 
> the Adapter only acting on the unwrapped resource which is not equal to the 
> wrapped one.
> This leads to unexpected behaviour when verifying interactions with mocks 
> taking the resource as argument, as the wrapped resource is never equal to 
> the resource used in the Sling Model given to the mock.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to