[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630447#comment-17630447 ] Stefan Seifert commented on SLING-11507: i've looked at the PR

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630380#comment-17630380 ] Dirk Rudolph commented on SLING-11507: -- I am wondering, if we also should fail for injections of

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630363#comment-17630363 ] Robert Munteanu commented on SLING-11507: - Thanks for taking this up [~diru]! > Field injection

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630317#comment-17630317 ] Angela Schreiber commented on SLING-11507: -- [~diru], thanks a lot! your post and me pinging

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630313#comment-17630313 ] Angela Schreiber commented on SLING-11507: -- hi [~sseifert] and [~kwin], it would be awesome if

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630312#comment-17630312 ] Dirk Rudolph commented on SLING-11507: -- I don't know the full history of this either, but agree

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628967#comment-17628967 ] Robert Munteanu commented on SLING-11507: - [~angela] - looking at the contributors list (

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628946#comment-17628946 ] Angela Schreiber commented on SLING-11507: -- [~rombert], sounds good to me. IMHO having static

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628697#comment-17628697 ] Carsten Ziegeler commented on SLING-11507: -- [~rombert] That approach sounds right to me >

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628266#comment-17628266 ] Robert Munteanu commented on SLING-11507: - Ok, so the approach seems to be something like: -

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627496#comment-17627496 ] Carsten Ziegeler commented on SLING-11507: -- [~rombert] True, a static method could be written

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627018#comment-17627018 ] Robert Munteanu commented on SLING-11507: - I can definitely extend this to static methods. It

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626679#comment-17626679 ] Carsten Ziegeler commented on SLING-11507: -- I was wondering if we should extend this to methods

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626674#comment-17626674 ] Robert Munteanu commented on SLING-11507: - Created a Draft PR that shows how this can look -

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626410#comment-17626410 ] Carsten Ziegeler commented on SLING-11507: -- Unfortunately, just looking at the header is not

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625766#comment-17625766 ] Robert Munteanu commented on SLING-11507: - What is the tooling entry point that we would have

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597070#comment-17597070 ] Joerg Hoh commented on SLING-11507: --- [~cziegeler] Valid point. We should always print a warning and

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597025#comment-17597025 ] Carsten Ziegeler commented on SLING-11507: -- This is clearly a developer error and should be