[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-18 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132189#comment-16132189 ] Robert Munteanu commented on SLING-7055: Applied. Missed them due to my using git-

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-18 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132180#comment-16132180 ] Marcel Reutegger commented on SLING-7055: - It appears the svn:ignore properties at

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131728#comment-16131728 ] Carsten Ziegeler commented on SLING-7055: - [~rombert] Lgtm, I think we should rena

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130735#comment-16130735 ] Robert Munteanu commented on SLING-7055: Patch LGTM. [~cziegeler], any other comme

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130637#comment-16130637 ] Marcel Reutegger commented on SLING-7055: - bq. However I hope that an absolute pat

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130524#comment-16130524 ] Carsten Ziegeler commented on SLING-7055: - Sorry I should have looked more closely

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130517#comment-16130517 ] Marcel Reutegger commented on SLING-7055: - The framework property is optional. The

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130501#comment-16130501 ] Carsten Ziegeler commented on SLING-7055: - Well relying on the framework property

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130469#comment-16130469 ] Robert Munteanu commented on SLING-7055: > I'd love to remove that dependency, but

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130326#comment-16130326 ] Marcel Reutegger commented on SLING-7055: - Thanks for the feedback. bq. remove th

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

2017-08-17 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130310#comment-16130310 ] Robert Munteanu commented on SLING-7055: Thanks for the patch [~mreutegg] . I woul