[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620300#comment-16620300
]
Robert Munteanu commented on SLING-7890:
Confirmed, thanks a lot [~jebailey]!
> JSON-related IT
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619481#comment-16619481
]
Jason E Bailey commented on SLING-7890:
---
[~rombert] You should be able to update the tests and have
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619174#comment-16619174
]
Jason E Bailey commented on SLING-7890:
---
looking into it
> JSON-related IT failures when upgrading
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619159#comment-16619159
]
Robert Munteanu commented on SLING-7890:
[~jebailey] - I still get test failures with:
* locally
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618960#comment-16618960
]
Robert Munteanu commented on SLING-7890:
[~jebailey] - I'll release the IT bundle anyway for the
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618899#comment-16618899
]
Jason E Bailey commented on SLING-7890:
---
[~rombert] Yes it's ready to be released. I was hoping to
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618687#comment-16618687
]
Robert Munteanu commented on SLING-7890:
[~jebailey] - so should we be safe to release the new
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617816#comment-16617816
]
Jason E Bailey commented on SLING-7890:
---
[~rombert] 2.1.34, as it stands, has a bug and should not
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617787#comment-16617787
]
Robert Munteanu commented on SLING-7890:
[~jebailey] - are you still looking into this? It's ok
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611273#comment-16611273
]
Bertrand Delacretaz commented on SLING-7890:
Ok got it, so I agree with changing the
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610943#comment-16610943
]
Jason E Bailey commented on SLING-7890:
---
[~bdelacretaz] You got the tests right, it's that I had
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610869#comment-16610869
]
Bertrand Delacretaz commented on SLING-7890:
I have added some tests for the {{JsonRenderer}}
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610724#comment-16610724
]
Robert Munteanu commented on SLING-7890:
Then I guess that the correct behaviour is to have the
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610720#comment-16610720
]
Jason E Bailey commented on SLING-7890:
---
[~rombert] Correct.
> JSON-related IT failures when
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610718#comment-16610718
]
Robert Munteanu commented on SLING-7890:
Nice investigation [~jebailey]! So, IIUC, the "native"
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610625#comment-16610625
]
Jason E Bailey commented on SLING-7890:
---
Additional information
The issue that is occurring is
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610242#comment-16610242
]
Robert Munteanu commented on SLING-7890:
{quote}Personally I would prefer that we keep the old,
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609975#comment-16609975
]
Jason E Bailey commented on SLING-7890:
---
[~bdelacretaz] So something is odd here. The reason this
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609770#comment-16609770
]
Bertrand Delacretaz commented on SLING-7890:
Ok, got it - sorry that I didn't figure it out
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609761#comment-16609761
]
Jason E Bailey commented on SLING-7890:
---
[~bdelacretaz] yes there is a difference in the output,
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609733#comment-16609733
]
Bertrand Delacretaz commented on SLING-7890:
The commit that you mention is
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607251#comment-16607251
]
Jason E Bailey commented on SLING-7890:
---
[~rombert] I've committed changes to both the default
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607120#comment-16607120
]
Jason E Bailey commented on SLING-7890:
---
There's a number of tests failing related to my changes
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607027#comment-16607027
]
Jason E Bailey commented on SLING-7890:
---
I see the problem. I'll work on the fix and a unit test.
[
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606879#comment-16606879
]
Robert Munteanu commented on SLING-7890:
[~jebailey] - since you did most of the changes between
25 matches
Mail list logo
