[
https://issues.apache.org/jira/browse/SLING-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-6249:
------------------------------------
Comment: was deleted
(was: Ok, I think we should definitely rename DEFAULT_SERVLET_NAME - it is a
resource type, and also rename DEFAULT_ERROR_HANDLER_NAME, it is a (http)
method name
SLING_SERLVET_NAME (we should fix the typo :) ) is used to provide the return
value for ServletConfig.getServletName - it's not super useful, but ok to move
it as well.
I think the javadocs of the individual constants need some updates if we move
them to public api)
> Move ServletResolverConstants to an exported package
> ----------------------------------------------------
>
> Key: SLING-6249
> URL: https://issues.apache.org/jira/browse/SLING-6249
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Servlets Resolver 2.4.6
> Reporter: Konrad Windszus
>
> The constants being defined in
> {{o.a.s.servlets.resolver.internal.ServletResolverConstants}} are not only
> useful for the servlet resolver bundle itself but basically for every Sling
> Servlet being defined without the custom Felix SCR annotations. Therefore it
> would be good to move that to a package which is exported (and therefore part
> of the public API). Although in reality all constant Strings are inline in
> Java (which means that there should never be a runtime dependency towards
> that class) it does not even appear in
> http://sling.apache.org/apidocs/sling7/ nor in
> https://sling.apache.org/apidocs/sling7/constant-values.html. Also the
> constants are not part of the uber-jar being generated for the Sling API as
> well for AEM
> (https://docs.adobe.com/docs/en/aem/6-1/develop/dev-tools/ht-projects-maven.html#What%20is%20the%20UberJar?).
> This was first requested in
> http://www.mail-archive.com/dev@sling.apache.org/msg45467.html and became
> more important with the advent of OSGi 6 component annotations (see also
> FELIX-5396).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
