[ https://issues.apache.org/jira/browse/SLING-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904948#action_12904948 ]
Carsten Ziegeler commented on SLING-1213: ----------------------------------------- Can you point to the changes regarding the filter handling? The patch is rather long :) Just noticed a typo in ServletFilterManager: the enum for request is just "Reques" > Filters to support servlet-API-level scope configuration > -------------------------------------------------------- > > Key: SLING-1213 > URL: https://issues.apache.org/jira/browse/SLING-1213 > Project: Sling > Issue Type: Improvement > Components: Engine > Reporter: Mike Pfaff > > Currently the filter.scope supports either > - component (comparable to <dispatcher>INCLUDE,FORWARD,ERROR</dispatcher> of > the servlet API) > or > - request (comparable to <dispatcher>REQUEST</dispatcher> of the servlet API) > In certain cases one wants to have finer control over the filter scopes, e.g. > have a filter that would do <dispatcher>REQUEST,FORWARD</dispatcher>, so that > the filter is applied first for the request and then again when you do a > requestDispatcher.forward(). > Therefore i suggest that the filter.scope should be enhanced as follows: > - Make filter.scope a multi-value property > - Add filter scopes: include, forward and error > - The existing filter scope "component"(quasi an alias for > "include,forward,error") should for backward-compatibility not change. > - Add filter chains for the new filter scopes (don't know if this is needed > internally?) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.