[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907555#action_12907555
]
Felix Meschberger commented on SLING-1739:
--
Thanks for providing the patch.
I agr
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907689#action_12907689
]
Jason Rose commented on SLING-1739:
---
I moved spi/helpers to the private packages header a
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907709#action_12907709
]
Justin Edelson commented on SLING-1739:
---
-1 on exporting spi and helpers. These packa
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907767#action_12907767
]
Felix Meschberger commented on SLING-1739:
--
Reverted the export of the slf4j.helpe
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907832#action_12907832
]
Justin Edelson commented on SLING-1739:
---
Jason - what version of mina are you using?
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907834#action_12907834
]
Jason Rose commented on SLING-1739:
---
The jar included with servicemix 4.2.0 is mina-core-
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908003#action_12908003
]
Justin Edelson commented on SLING-1739:
---
I get it now; I wasn't seeing the spi depend
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909774#action_12909774
]
Justin Edelson commented on SLING-1739:
---
Both mina and karaf have now been fixed.
>
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910092#action_12910092
]
Felix Meschberger commented on SLING-1739:
--
So can we then resolve this with just
[
https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910138#action_12910138
]
Justin Edelson commented on SLING-1739:
---
>So can we then resolve this with just upgra
Hi,
I am tempted to agree with respect to SPI, of course.
With respect to helpers, I am not really sure. Looking at the mina.core
code, they have some class in there which uses the BasicMDCAdapter class
from the helpers package.
As for exposing a Sling-repackage: I think if we consider replacing
Hmm. but MDCAdapter is part of the SPI so it looks like you can't use
it without spi.
I'll take a look at the mina code.
I don't think I explained myself very well with respect to the Sling
repackaging. I didn't literally mean copying org.slf4j.spi.* to
org.apache.sling.log.spi.*. I meant coming
I looked at the source references in both mina and karaf. In both cases,
I believe they're using these classes inappropriately and unnecessarily.
See DIRMINA-794 and KARAF-198, both with relatively simply patches.
However, what I didn't see is any dependency from mina on the spi
package. I put a c
13 matches
Mail list logo
