Re: Add builders to create request/response objects

2021-10-16 Thread Carsten Ziegeler
I've created an issue and did a first step at the implementation at https://issues.apache.org/jira/browse/SLING-10871 The api is based on what we have in servlet helpers today, with some fixes and minor changes. In addition I added some methods which allow to reuse parts of an existing request

Re: Add builders to create request/response objects

2021-10-06 Thread Oliver Lietz
On Wednesday, 29 September 2021 18:40:39 CEST Carsten Ziegeler wrote: > Hi, > > in https://issues.apache.org/jira/browse/SLING-10840 we have some > lengthy discussion about the servlet helpers bundle, where and how it > should be used and the problem with it implementing ProviderType interfaces. >

Re: Add builders to create request/response objects

2021-09-30 Thread Bertrand Delacretaz
On Thu, Sep 30, 2021 at 10:23 AM Carsten Ziegeler wrote: > ...I'll probably create a prototype in the whiteboard which we then can > further discuss.. +1, and note that the InternalRequest and child classes at [1] already define a "builder protocol" that can probably apply in the same way to crea

Re: Add builders to create request/response objects

2021-09-30 Thread Carsten Ziegeler
Hi, Am 30.09.2021 um 09:47 schrieb Bertrand Delacretaz: Hi, On Wed, Sep 29, 2021 at 6:40 PM Carsten Ziegeler wrote: ...we should probably have some proper API to create an initial request and response without backing it out or wrapping an existing request / response... IIUC you mean a servi

Re: Add builders to create request/response objects

2021-09-30 Thread Bertrand Delacretaz
Hi, On Wed, Sep 29, 2021 at 6:40 PM Carsten Ziegeler wrote: > ...we should probably have some proper > API to create an initial request and response without backing it out or > wrapping an existing request / response... IIUC you mean a service or utility class that provides objects that implemen

Add builders to create request/response objects

2021-09-29 Thread Carsten Ziegeler
Hi, in https://issues.apache.org/jira/browse/SLING-10840 we have some lengthy discussion about the servlet helpers bundle, where and how it should be used and the problem with it implementing ProviderType interfaces. The gist of it, is that the main purpose of this bundle is to be used in te