RE: Authentication Info Post Processing vs. Authentication Info Validation

2010-08-18 Thread Mike Müller
>>> snip snap > I happen to dislike plain Exception. > > How about this: > > * We declare LoginException as a checked exception which may > be thrown and handled like LoginException thrown from the > ResourceResolverFactory.getResourceResolver method > * Document SlingException may be t

Re: Authentication Info Post Processing vs. Authentication Info Validation

2010-08-17 Thread Felix Meschberger
Hi, On 17.08.2010 08:35, Mike Müller wrote: snip snap >>> So my suggestion is to make a tiny enhancement to the >>> AuthenticationInfoPostProcessor and to abandon my patch with >>> the CredentialsValidator. >>> I would let the postProcess method throw an exception in which >>> case Sling shou

RE: Authentication Info Post Processing vs. Authentication Info Validation

2010-08-17 Thread Mike Müller
>>> snip snap > > So my suggestion is to make a tiny enhancement to the > > AuthenticationInfoPostProcessor and to abandon my patch with > > the CredentialsValidator. > > I would let the postProcess method throw an exception in which > > case Sling should abort the request dispatching. Because in t

Re: Authentication Info Post Processing vs. Authentication Info Validation

2010-08-16 Thread Justin Edelson
On Mon, Aug 16, 2010 at 7:02 AM, Mike Müller wrote: >> While looking at the CredentialValidator patch by Mike >> (SLING-1593 [1]) >> I came across the Authentication Info post processor infrastructure >> introduced by Justin (SLING-1444 [2]). >> >> Now, I am bit worried of having two mechanisms wi

RE: Authentication Info Post Processing vs. Authentication Info Validation

2010-08-16 Thread Mike Müller
> While looking at the CredentialValidator patch by Mike > (SLING-1593 [1]) > I came across the Authentication Info post processor infrastructure > introduced by Justin (SLING-1444 [2]). > > Now, I am bit worried of having two mechanisms with different services > basically doing the same thing: Tak

Authentication Info Post Processing vs. Authentication Info Validation

2010-08-16 Thread Felix Meschberger
Hi all, While looking at the CredentialValidator patch by Mike (SLING-1593 [1]) I came across the Authentication Info post processor infrastructure introduced by Justin (SLING-1444 [2]). Now, I am bit worried of having two mechanisms with different services basically doing the same thing: Take an