Re: Health checks execution service

2013-10-29 Thread Bertrand Delacretaz
On Tue, Oct 29, 2013 at 9:11 AM, Carsten Ziegeler wrote: > ...maybe, if we go with the executor service and have additional metadata > (service properties) on the health checks indicating if they are long > running etc. this could be handled in the executor service... While the intention is fine

Re: Health checks execution service

2013-10-29 Thread Carsten Ziegeler
I'm not sure if a separate interface is a good thing - this requires the developer to choose and if we makes the wrong choice there is no way to correct this other than changing the implementation - and if we consider today that 1 minutes is the limit but decide tomorrow that it's 30 seconds this g

Re: Health checks execution service

2013-10-28 Thread Felix Meschberger
Hi Apart from JMX (which is a separate biest), I agree, that we have to think about fixing the long-running check issue. How about a „LongRunningHealthCheck“ service ? Such services would be picked up by the HealthCheck infrastructure and execute as tasks (maybe the service properties could ev

Re: Health checks execution service

2013-10-28 Thread Bertrand Delacretaz
On Mon, Oct 28, 2013 at 3:51 PM, Carsten Ziegeler wrote: >... I think these are different issues. Im not against the service per se (need > to think about it), but getting an attribute of an bmean should not alter > its state Agreed, if that can be implemented without having to reinvent thing

Re: Health checks execution service

2013-10-28 Thread Felix Meschberger
Yes, the problems are really different and must be handled differently. And yes, both are problems, indeed. Regards Felix — Felix Meschberger | Principal Scientist | Adobe Am 28.10.2013 um 15:51 schrieb Carsten Ziegeler : > I think these are different issues. Im not against the service p

Re: Health checks execution service

2013-10-28 Thread Carsten Ziegeler
I think these are different issues. Im not against the service per se (need to think about it), but getting an attribute of an bmean should not alter its state. Carsten Am 28.10.2013 10:11 schrieb "Bertrand Delacretaz" : > Hi, > > Looking at SLING-3207 I think this deserves a bit more discussion:

Health checks execution service

2013-10-28 Thread Bertrand Delacretaz
Hi, Looking at SLING-3207 I think this deserves a bit more discussion: I don't think this is only about JMX, and providing an executor service that takes care of caching and async execution can help make the individual health checks simpler. >From a client's point of view I would suggest the foll