Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1611600431 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-21 Thread via GitHub
rishabhdaim commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1608464507 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-21 Thread via GitHub
jsedding commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1608323556 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2120007654 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113317468 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113316059 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113311666 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113206440 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
rombert commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2112452359 @rishabhdaim - can you please merge with the latest master commit?

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-15 Thread via GitHub
rombert commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1601372208 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigUtil.java: ## @@ -336,4 +337,20 @@ public

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2096967292 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2049658267 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-04-09 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2046510173 ## [![Quality Gate