Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-08-22 Thread via GitHub
jsedding commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#issuecomment-2304124127 Superseeded by #15. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-08-22 Thread via GitHub
jsedding closed pull request #14: SLING-12315: avoid new registrations during deactivation URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-05-14 Thread via GitHub
jsedding commented on code in PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#discussion_r1601048338 ## src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java: ## @@ -436,8 +439,10 @@ protected void deactivate() { this.lo

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-05-14 Thread via GitHub
rombert commented on code in PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#discussion_r1599862705 ## src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java: ## @@ -436,8 +439,10 @@ protected void deactivate() { this.loc

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#issuecomment-2107393290 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')]

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-05-11 Thread via GitHub
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#issuecomment-2106042064 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')]

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

2024-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#issuecomment-2101220350 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')]