Re: Resource Filter API ( was: [VOTE] Release Apache Sling Resource Filter version 1.0.0)

2018-08-24 Thread Robert Munteanu
Thanks for iterating on this - from my point of view the API looks quite good. Thanks, Robert On Thu, 2018-08-23 at 11:37 -0400, Jason E Bailey wrote: > I appreciate the more in depth feedback, when you've worked on > something for a while it's hard to see it from a different point of > view. >

Re: Resource Filter API ( was: [VOTE] Release Apache Sling Resource Filter version 1.0.0)

2018-08-23 Thread Jason E Bailey
I appreciate the more in depth feedback, when you've worked on something for a while it's hard to see it from a different point of view. - Jason On Thu, Aug 23, 2018, at 5:19 AM, Robert Munteanu wrote: > My notes are as follows: > > a. Do we need custom exceptions? I.e., do we expect consumers

Resource Filter API ( was: [VOTE] Release Apache Sling Resource Filter version 1.0.0)

2018-08-23 Thread Robert Munteanu
Hi Jason, On Tue, 2018-08-21 at 08:30 -0400, Jason E Bailey wrote: > Hi Robert, > > I'll need to clarify the documentation. > > The ResourceFilter is the object that converts a String to a > Predicate , there are cases where you want the > ResourceFilter Script to evaluate against a provided ja