[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
enapps-enorman commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171858959 > @enapps-enorman I used your suggestions but that requires the output to have quotes when it contains special character like the hashtag

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171838566 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
schaefa commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171837314 @enapps-enorman I used your suggestions but that requires the output to have quotes when it contains special character like the hashtag (RegisterNamespace

[jira] [Resolved] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2022-06-30 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10740. - Resolution: Fixed Merged PR #27 at:

[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman merged pull request #27: SLING-10740 implemention for create path with properties

2022-06-30 Thread GitBox
enapps-enorman merged PR #27: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Resolved] (SLING-11431) Cleanup compiler and sonar warnings

2022-06-30 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-11431. - Resolution: Fixed Merged PR #20 at:  

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
enapps-enorman commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171766851 > I did that but now the test fails because the hashtag went missing @schaefa Take a look at the what I stashed in my fork at:

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
schaefa commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171763417 I did that but now the test fails because the hashtag went missing -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
enapps-enorman commented on code in PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123 ## src/test/resources/testcases/test-40-output.txt: ## @@ -1,3 +1,3 @@ RegisterNamespace (foo) uri:some-uri/V/1.0 RegisterNamespace

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
enapps-enorman commented on code in PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123 ## src/test/resources/testcases/test-40-output.txt: ## @@ -1,3 +1,3 @@ RegisterNamespace (foo) uri:some-uri/V/1.0 RegisterNamespace

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
enapps-enorman commented on code in PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123 ## src/test/resources/testcases/test-40-output.txt: ## @@ -1,3 +1,3 @@ RegisterNamespace (foo) uri:some-uri/V/1.0 RegisterNamespace

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
schaefa commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171744468 I updated the code to showcase the issue. I tried multiple things: \#: fails the repo init parser test \\#: fails the repo init parser test #:

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman merged pull request #20: SLING-11431 cleanup many compiler and sonar warnings

2022-06-30 Thread GitBox
enapps-enorman merged PR #20: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Created] (SLING-11431) Cleanup compiler and sonar warnings

2022-06-30 Thread Eric Norman (Jira)
Eric Norman created SLING-11431: --- Summary: Cleanup compiler and sonar warnings Key: SLING-11431 URL: https://issues.apache.org/jira/browse/SLING-11431 Project: Sling Issue Type: Improvement

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
schaefa commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171735204 I tried that but I could not get the '#' in. Either it is ignored or I have '\#'. The quotedString() is not converting an escaped backslash. Even when I fix

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #86: Bump jsdom from 16.2.2 to 16.7.0 in /slingpost

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #86: URL: https://github.com/apache/sling-whiteboard/pull/86#issuecomment-1171565959 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #82: Bump async from 2.6.3 to 2.6.4 in /slingpost

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #82: URL: https://github.com/apache/sling-whiteboard/pull/82#issuecomment-1171565544 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1171508344 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: Repo-Init: register Namespace with a trailing hashtag (#)

2022-06-30 Thread Andreas Schaefer
I created a simple solution to allow for a hashtag inside the URI with: register namespace (foo2) http://test.com/v/1.0\# The PR link is: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24

[jira] [Assigned] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11430: --- Assignee: Konrad Windszus > Do no longer generate full baseline report in case of

[jira] [Updated] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11430: Description: The report being emitted by default has been improved in newer

[jira] [Resolved] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11430. - Resolution: Fixed Fixed in

[jira] [Updated] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11430: Description: The report being emitted by default has been improved in newer

[jira] [Created] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11430: --- Summary: Do no longer generate full baseline report in case of failure Key: SLING-11430 URL: https://issues.apache.org/jira/browse/SLING-11430 Project: Sling

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
kwin commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171471760 I would recommend moving the impl classes to some non-exported impl packages and only ignore those during baselining for now. -- This is an automated message from

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1171458985 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1171459450 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
kwin commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171456991 The major version bump is not necessary due to the annotation type change, but due to backwards incompatible changes in

[GitHub] [sling-org-apache-sling-discovery-base] sonarcloud[bot] commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171413600 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-discovery-base] ashokmca07 commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
ashokmca07 commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171405183 @kwin Unfortunately `bnd-baseline-maven-plugin` is still not happy after the micro(!) version bump. but to avoid major version bump, I set

[jira] [Assigned] (SLING-11429) OSGi configs on same resource type cause IAE

2022-06-30 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-11429: Assignee: Radu Cotescu > OSGi configs on same resource type cause IAE >

[jira] [Created] (SLING-11429) OSGi configs on same resource type cause IAE

2022-06-30 Thread Stefan Grimm (Jira)
Stefan Grimm created SLING-11429: Summary: OSGi configs on same resource type cause IAE Key: SLING-11429 URL: https://issues.apache.org/jira/browse/SLING-11429 Project: Sling Issue Type:

[GitHub] [sling-org-apache-sling-jcr-contentparser] ashokmca07 closed pull request #3: deprecated labels has been added

2022-06-30 Thread GitBox
ashokmca07 closed pull request #3: deprecated labels has been added URL: https://github.com/apache/sling-org-apache-sling-jcr-contentparser/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (SLING-11417) Update parent bundle (48) to sling-installer-provider-installhook

2022-06-30 Thread Ashok Pelluru (Jira)
[ https://issues.apache.org/jira/browse/SLING-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-11417. --- Resolution: Fixed > Update parent bundle (48) to sling-installer-provider-installhook >

[GitHub] [sling-org-apache-sling-installer-provider-installhook] ashokmca07 merged pull request #3: SLING-11417: Upgrade to sling 48

2022-06-30 Thread GitBox
ashokmca07 merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-installhook/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
bdelacretaz commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171374356 We already have a `quotableString()` production in the grammar, would it be an option to allow for quoting the namespace URI for such cases? The input

[GitHub] [sling-maven-launchpad-plugin] dependabot[bot] opened a new pull request, #1: Bump plexus-archiver from 1.0-alpha-9 to 3.6.0

2022-06-30 Thread GitBox
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/sling-maven-launchpad-plugin/pull/1 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 1.0-alpha-9 to 3.6.0. Release notes Sourced from

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on a diff in pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
kwin commented on code in PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r910947467 ## src/main/java/org/apache/sling/discovery/base/commons/package-info.java: ## @@ -23,8 +23,7 @@ * * @version 1.1.0 */ -@Version("2.0.0")

[GitHub] [sling-org-apache-sling-discovery-base] ashokmca07 commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
ashokmca07 commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171011270 > * bump the versions, verify that the consuming Sling bundles ( other discovery bundles I assume ) still work, and update the consuming Sling bundles import

[jira] [Resolved] (SLING-11425) Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11425. - Resolution: Fixed https://github.com/apache/sling-org-apache-sling-xss/pull/25 merged,

[jira] [Assigned] (SLING-11425) Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11425: --- Assignee: Robert Munteanu > Make URI filtering test more lenient in case of

[GitHub] [sling-org-apache-sling-xss] rombert merged pull request #25: SLING-11425 Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread GitBox
rombert merged PR #25: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #25: SLING-11425 Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread GitBox
sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/25#issuecomment-1170998818 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-discovery-base] rombert commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1170988112 @ashokmca07 - If I understand correctly, the SCR components are exported, which means that changed methods/annotations also change the API. To be honest I am not

Re: [VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Robert Munteanu
On Thu, 2022-06-30 at 09:23 +0200, Konrad Windszus wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox
anchela commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1170878577 @schaefa , thanks for the patch. can you please ask @bdelacretaz for a review? i am busy and don't have time for a thorough review, while he is the author of

RE: [VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Stefan Seifert
+1 stefan

Re: [VOTE] Release Apache Sling Health Check Support version 1.0.8

2022-06-30 Thread Georg Henzler
+1 - Georg On 2022-06-28 22:30, Eric Norman wrote: Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12349321 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2651/ You can use this UNIX script to download

[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x

2022-06-30 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560889#comment-17560889 ] Georg Henzler commented on SLING-11141: --- Let's move forward, we can deprecate this

[VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Konrad Windszus
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING-11362 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2652/ You can use this UNIX script to download the release and verify the signatures: