Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

+1 Carsten Am 19.07.2022 um 00:03 schrieb Oliver Lietz: Hi, We solved 4 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12345553 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2656 You can use this UNIX script to

[VOTE] Release Apache Sling Installer Health Checks 2.1.0

Hi, We solved 4 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12345553 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2656 You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-11462) Reduce memory requirements by not allocating a 256 MiB buffer

[ https://issues.apache.org/jira/browse/SLING-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11462. - Resolution: Fixed > Reduce memory requirements by not allocating a 256 MiB buffer >

[GitHub] [sling-org-apache-sling-feature-launcher] rombert merged pull request #41: SLING-11462 - Reduce memory requirements by not allocating a 256 MiB buffer

rombert merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (SLING-11463) Reconfigure OsgiInstallerHealthCheck when configuration is modified

[ https://issues.apache.org/jira/browse/SLING-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11463. -- Resolution: Done > Reconfigure OsgiInstallerHealthCheck when configuration is modified >

[jira] [Created] (SLING-11463) Reconfigure OsgiInstallerHealthCheck when configuration is modified

Oliver Lietz created SLING-11463: Summary: Reconfigure OsgiInstallerHealthCheck when configuration is modified Key: SLING-11463 URL: https://issues.apache.org/jira/browse/SLING-11463 Project: Sling

[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

schaefa commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1188277883 @kwin You give it a try (on both execute() methods): try (JsonWriter writer = Json.createWriter(CloseShieldWriter.wrap(response.getWriter( {

[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

kwin commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1188253002 `close()` is the last method called on an instance of try with resources so I fail to see how this would have a negative impact. The CloseShieldWriter uses that to

Mock Sling Http Servlet Response Writer does not check if already closed

Hi I wanted to add a test to the GraphQLServlet to make sure that the closure of the Writer is causing a test failure but the Response Content Support does not support that. So I wanted to suggest a flag on the Mock Sling Http Servlet Response that would allow to use the same Delete Print

[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

schaefa commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-118804 @kwin The Close Shield Writer is not just preventing the close but it is replacing the writer: public void close() { this.out =

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #348 is FIXED

Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/348/ for details. No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1187902185 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

kwin commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1187888071 > First this does not work as it replaces the writer when closed is called I am not following here. You can just use `try (JsonWriter writer =

[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626

schaefa commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1187841108 @kwin First this does not work as it replaces the writer when closed is called but I also think that we should make it explicit there as this is important. Also

[GitHub] [sling-org-apache-sling-discovery-base] sonarcloud[bot] commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1187647023 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-discovery-base] ashokmca07 commented on a diff in pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

ashokmca07 commented on code in PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r923503557 ## src/main/java/org/apache/sling/discovery/base/commons/package-info.java: ## @@ -23,8 +23,7 @@ * * @version 1.1.0 */

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on a diff in pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

kwin commented on code in PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r923498422 ## src/main/java/org/apache/sling/discovery/base/connectors/announcement/CachedAnnouncement.java: ## @@ -43,7 +43,7 @@ public class

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #29: SLING-11461 : Reduce complexity

sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/29#issuecomment-1187630256 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-resource] anchela opened a new pull request, #29: SLING-11461 : Reduce complexity

anchela opened a new pull request, #29: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/29 @joerghoh , @cziegeler , i would appreciate if you had time to look at the patch reducing complexity of some cases that are easy to refactor. note that the patch also aims

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

stefan-egli commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1187584073 I think both options (from @kwin and @rombert) work fine. These impl classes should not have been exported (by myself) in the first place and i would

[jira] [Assigned] (SLING-11442) Allow blocking after the features have been launched

[ https://issues.apache.org/jira/browse/SLING-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11442: --- Assignee: (was: Robert Munteanu) > Allow blocking after the features have been

[jira] [Commented] (SLING-11442) Allow blocking after the features have been launched

[ https://issues.apache.org/jira/browse/SLING-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568001#comment-17568001 ] Robert Munteanu commented on SLING-11442: - [~kwin] - I agree with your analysis, I am also not

[GitHub] [sling-org-apache-sling-distribution-it] ashokmca07 commented on pull request #1: SLING-11287: Initial commit to start with slingstart plugin

ashokmca07 commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-distribution-it/pull/1#issuecomment-1187452701 FYI: Tests are green from local, but trying to make them happy through Jenkins as well. -- This is an automated message from the Apache Git Service. To

[GitHub] [sling-org-apache-sling-discovery-base] rombert commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1187428269 > I would recommend moving the impl classes to some non-exported impl packages and only ignore those during baselining for now. Another option, though more

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #41: SLING-11462 - Reduce memory requirements by not allocating a 256 MiB buffer

sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/41#issuecomment-1187407637 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-launcher] rombert opened a new pull request, #41: SLING-11462 - Reduce memory requirements by not allocating a 256 MiB buffer

rombert opened a new pull request, #41: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/41 Use Files#copy instead of manually copying data between streams. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (SLING-11462) Reduce memory requirements by not allocating a 256 MiB buffer

[ https://issues.apache.org/jira/browse/SLING-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11462: Description: The Feature Launcher allocated a 256 MiB array unconditionally, see [1]. It

[jira] [Commented] (SLING-11462) Reduce memory requirements if feature archives are not used

[ https://issues.apache.org/jira/browse/SLING-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567990#comment-17567990 ] Robert Munteanu commented on SLING-11462: - Thanks [~kwin], I'm working on an alternative PR

[jira] [Updated] (SLING-11462) Reduce memory requirements by not allocating a 256 MiB buffer

[ https://issues.apache.org/jira/browse/SLING-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11462: Summary: Reduce memory requirements by not allocating a 256 MiB buffer (was: Reduce

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #40: SLING-11462 - Reduce memory requirements if feature archives are not used

sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/40#issuecomment-1187382629 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567985#comment-17567985 ] Joerg Hoh commented on SLING-11449: --- [~reschke] I created OAK-9845 for it. > Use

[jira] [Commented] (SLING-11462) Reduce memory requirements if feature archives are not used

[ https://issues.apache.org/jira/browse/SLING-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567983#comment-17567983 ] Konrad Windszus commented on SLING-11462: - We should use

[GitHub] [sling-org-apache-sling-feature-launcher] rombert closed pull request #40: SLING-11462 - Reduce memory requirements if feature archives are not used

rombert closed pull request #40: SLING-11462 - Reduce memory requirements if feature archives are not used URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #40: SLING-11462 - Reduce memory requirements if feature archives are not used

rombert commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/40#issuecomment-1187373469 I missed an opportunity to use a Java8-compatible version of Files#copyTo as pointed out by @kwin , closing. -- This is an automated message from the

Re: 256 MB static buffer in the feature launcher

On Mon, 2022-07-18 at 15:02 +0200, Konrad Windszus wrote: > https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#copy(java.io.InputStream,%20java.nio.file.Path,%20java.nio.file.CopyOption...) >  < >

[jira] [Updated] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11449: -- Fix Version/s: JCR Resource 3.2.2 > Use JackrabbitNode.getPropertyOrNull >

[jira] [Resolved] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11449. --- Resolution: Fixed > Use JackrabbitNode.getPropertyOrNull > > >

[GitHub] [sling-org-apache-sling-feature-launcher] rombert opened a new pull request, #40: SLING-11462 - Reduce memory requirements if feature archives are not used

rombert opened a new pull request, #40: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/40 Lazily initialise the buffer used for reading feature model archives. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: 256 MB static buffer in the feature launcher

https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#copy(java.io.InputStream,%20java.nio.file.Path,%20java.nio.file.CopyOption...)

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh merged pull request #28: SLING-11449: Use latest improvements of Oak 1.44.0

joerghoh merged PR #28: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: 256 MB static buffer in the feature launcher

Hi, On Sat, 2022-07-09 at 09:28 -0700, Eric Norman wrote: > I'd probably try to get rid of that buffer variable and just use > java.nio.file.Files#copy to copy the inputstream to the target path. That is a good idea. Unfortunately, we still target Java 8 with the feature launcher and the

[jira] [Created] (SLING-11462) Reduce memory requirements if feature archives are not used

Robert Munteanu created SLING-11462: --- Summary: Reduce memory requirements if feature archives are not used Key: SLING-11462 URL: https://issues.apache.org/jira/browse/SLING-11462 Project: Sling

[jira] [Closed] (SLING-11438) Resource path consisting of %7D with multiple dots leads to path traversal

[ https://issues.apache.org/jira/browse/SLING-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11438. --- > Resource path consisting of %7D with multiple dots leads to path traversal >

[RESULT] [VOTE] Release Apache Sling Engine 2.9.2

Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Robert Munteanu, Carsten Ziegeler, Eric Norman +1 (non-binding): Sagar Miglani I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert

[jira] [Commented] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567953#comment-17567953 ] Julian Reschke commented on SLING-11449: This would bind Sling to Oak (latest) for the time

[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #4: SLING-11456 export mbeans as metrics

sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/4#issuecomment-1187158251 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #4: SLING-11456 export mbeans as metrics

sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/4#issuecomment-1187042632 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Assigned] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-11449: - Assignee: Joerg Hoh > Use JackrabbitNode.getPropertyOrNull >

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #28: SLING-11449: Use latest improvements of Oak 1.44.0

sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/28#issuecomment-1186978850 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #17: Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent

anchela commented on PR #17: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/17#issuecomment-1186887663 closing this PR as it has been solved by using the new method JackrabbitSession.getParentOrNull -- This is an automated message from the Apache Git Service. To

[GitHub] [sling-org-apache-sling-jcr-resource] anchela closed pull request #17: Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent

anchela closed pull request #17: Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #28: SLING-11449: Use latest improvements of Oak 1.44.0

sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/28#issuecomment-1186876980 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh opened a new pull request, #28: SLING-11449: Use latest improvements of Oak 1.44.0

joerghoh opened a new pull request, #28: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/28 In OAK-9819 the JackrabbitNode interface was extended by ```getPropertyOrNull``` which can improve the performance in the common case of this pattern: ``` if

[jira] [Commented] (SLING-11449) Use JackrabbitNode.getPropertyOrNull

[ https://issues.apache.org/jira/browse/SLING-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567855#comment-17567855 ] Joerg Hoh commented on SLING-11449: ---

[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #5: SLING-11355: sling discovery bundles: update to sling 48

sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/5#issuecomment-1186859399 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-distribution-sample] ashokmca07 merged pull request #2: SLING-11287: adjust distribution-sample for itegration-tests

ashokmca07 merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-distribution-sample/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #7: SLING-11450 : avoid suppressing instances that were seen previously

stefan-egli commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7#issuecomment-1186836912 This is due to a bug in discovery.base which the other PR https://github.com/apache/sling-org-apache-sling-discovery-base/pull/9 fixes. I should have noted

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli merged pull request #9: SLING-11450 : fix a mock class

stefan-egli merged PR #9: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (SLING-11461) Reduce complexity

Angela Schreiber created SLING-11461: Summary: Reduce complexity Key: SLING-11461 URL: https://issues.apache.org/jira/browse/SLING-11461 Project: Sling Issue Type: Sub-task

[jira] [Resolved] (SLING-11454) Add missing notnull/nullable annotations

[ https://issues.apache.org/jira/browse/SLING-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11454. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Add missing

[GitHub] [sling-org-apache-sling-jcr-resource] anchela merged pull request #27: SLING-11454 : Add missing notnull/nullable annotations

anchela merged PR #27: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: