Re: [PR] SLING-12263 Separate non-bundles from bundles [sling-site]
kwin commented on PR #158: URL: https://github.com/apache/sling-site/pull/158#issuecomment-1983723777 I was referring to https://github.com/apache/sling-site/blob/27d4e67d97511063d1e33b58e80847c80a357743/src/main/jbake/templates/downloads.tpl#L178-L186. At least https://github.com/apache/sling-org-apache-sling-launchpad-test-fragment is also a bundle. But I was mostly expecting that some more can be moved to deprecated. If you can add comments to the lines that should be moved I can include those changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12263 Separate non-bundles from bundles [sling-site]
rombert commented on PR #158: URL: https://github.com/apache/sling-site/pull/158#issuecomment-1983423730 @kwin - which modules exactly are you talking about? I would expect most of the launchpad modules to be "helpers", with the exception of the Launchpad API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824395#comment-17824395 ] Robert Munteanu commented on SLING-12262: - Right, I was just expecting that the window of opportunity when these metrics are available to be quite short, as the instance would be taken down. Not opposing the implementation, just asking :-) > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1290 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1290/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Commented] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824365#comment-17824365 ] Joerg Hoh commented on SLING-12262: --- We scrape metrics via prometheus and have an alertmanager instance to create alerts from it. If now an instance is not starting up, it's much easier to find out if repoinit is the culprit if you can query a metric than to search the logs for the characteristical exception of repoinit. That allows us to refine the "instance-not-starting-up" alert and convert it into an "instance-not-starting-up-because-of-repoinit-issues" alert, which is much more meaningful and which can be handled differently than the generic alert, which always requires the general triage process. > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12263 Separate non-bundles from bundles [sling-site]
kwin commented on PR #158: URL: https://github.com/apache/sling-site/pull/158#issuecomment-1983244758 @rombert Can you help moving the Launchpad modules to the right section? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12263 Separate non-bundles from bundles [sling-site]
kwin opened a new pull request, #158: URL: https://github.com/apache/sling-site/pull/158 Move some more deprecated Sling modules into the deprecated section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12263) Separate real OSGi bundles from simple JARs in Downloads page
[ https://issues.apache.org/jira/browse/SLING-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-12263: --- Assignee: Konrad Windszus > Separate real OSGi bundles from simple JARs in Downloads page > - > > Key: SLING-12263 > URL: https://issues.apache.org/jira/browse/SLING-12263 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently the page https://sling.apache.org/downloads.cgi#sling-components > has a section "Sling Components" which contains most of the Sling modules. > However not all in that list are bundles. > Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only > list real OSGi bundles there) and add an additional section named "Sling > Helpers" and list all JARs there which do not fit in any other category > (maven plugins, bnd plugins, IDE or Sling Application). > Those are primarily all annotation modules like > - https://github.com/apache/sling-adapter-annotations > - https://github.com/apache/sling-org-apache-sling-adapter-annotations > but also > - > https://github.com/apache/sling-org-apache-sling-installer-provider-installhook > ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12263) Separate real OSGi bundles from simple JARs in Downloads page
[ https://issues.apache.org/jira/browse/SLING-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12263: Summary: Separate real OSGi bundles from simple JARs in Downloads page (was: Separate real OSGi bundles from simple JARs) > Separate real OSGi bundles from simple JARs in Downloads page > - > > Key: SLING-12263 > URL: https://issues.apache.org/jira/browse/SLING-12263 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Konrad Windszus >Priority: Major > > Currently the page https://sling.apache.org/downloads.cgi#sling-components > has a section "Sling Components" which contains most of the Sling modules. > However not all in that list are bundles. > Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only > list real OSGi bundles there) and add an additional section named "Sling > Helpers" and list all JARs there which do not fit in any other category > (maven plugins, bnd plugins, IDE or Sling Application). > Those are primarily all annotation modules like > - https://github.com/apache/sling-adapter-annotations > - https://github.com/apache/sling-org-apache-sling-adapter-annotations > but also > - > https://github.com/apache/sling-org-apache-sling-installer-provider-installhook > ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12263) Separate real OSGi bundles from simple JARs
Konrad Windszus created SLING-12263: --- Summary: Separate real OSGi bundles from simple JARs Key: SLING-12263 URL: https://issues.apache.org/jira/browse/SLING-12263 Project: Sling Issue Type: Improvement Components: Site Reporter: Konrad Windszus Currently the page https://sling.apache.org/downloads.cgi#sling-components has a section "Sling Components" which contains most of the Sling modules. However not all in that list are bundles. Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only list real OSGi bundles there) and add an additional section named "Sling Helpers" and list all JARs there which do not fit in any other category (maven plugins, bnd plugins, IDE or Sling Application). Those are primarily all annotation modules like - https://github.com/apache/sling-adapter-annotations - https://github.com/apache/sling-org-apache-sling-adapter-annotations but also - https://github.com/apache/sling-org-apache-sling-installer-provider-installhook ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983151463 > @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? Did you mean the spotless-maven-plugin? IIRC that is only active for parent version 60 or newer, see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=284790344 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12247 Document Component Property Type for ResourceChangeListener [sling-site]
kwin merged PR #157: URL: https://github.com/apache/sling-site/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT][VOTE] Release Apache Sling Resource Observation Annotations 1.0.0
Hi, The vote has passed with the following result : +1 (binding): Robert, Radu, Jörg I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 1. Mar 2024, at 13:19, Konrad Windszus wrote: > > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354378=Text > > The source code is located in the new repository at > https://github.com/apache/sling-org-apache-sling-resource-observation-annotations. > > Its usage is described in https://github.com/apache/sling-site/pull/157 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2841/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2841 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks in advance for voting, > Konrad
[jira] [Closed] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12247. --- > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Components: Resource Observation Annotations >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Observation Annotations 1.0.0 > > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983018716 @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
