Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
kwin commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2050026016 What makes you think this is not supported with Parent 60? Compare with https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=284790344. -- This is an

Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2050022625 Because we still need to target Java 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
kwin commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2049995107 Why not 60? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (SLING-12291) Broken backwards compatibility for duplicated keys

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12291: --- Assignee: Remo Liechti > Broken backwards compatibility for duplicated keys >

Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]

2024-04-11 Thread via GitHub
rombert commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2049992800 @raducotescu - any comments? I plan to merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12291: Fix Version/s: Commons JSON 2.0.24 > Broken backwards compatibility for duplicated keys >

[jira] [Updated] (SLING-10506) Document inappropriate Sonar rules

2024-04-11 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-10506: - Description: * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100) * {{java:S112}}

[jira] [Created] (SLING-12291) Broken backwards compatibility for duplicated keys

2024-04-11 Thread Remo Liechti (Jira)
Remo Liechti created SLING-12291: Summary: Broken backwards compatibility for duplicated keys Key: SLING-12291 URL: https://issues.apache.org/jira/browse/SLING-12291 Project: Sling Issue

[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys

2024-04-11 Thread Remo Liechti (Jira)
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remo Liechti updated SLING-12291: - Affects Version/s: Commons JSON 2.0.24 > Broken backwards compatibility for duplicated keys >

RE: [VOTE] Release Apache Sling Tenant 1.1.8

2024-04-11 Thread Stefan Seifert
+1 stefan

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

2024-04-11 Thread via GitHub
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2049712912 @sufyanharoon - I agree that it can be used as a plain jar, but if you build it you will see that it's an OSGi bundle -

[VOTE] Release Apache Sling Tenant 1.1.8

2024-04-11 Thread Robert Munteanu
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354544=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2845/ You can use this UNIX script to download the release and verify the

[jira] [Resolved] (SLING-12290) Update tenant module to use parent pom 52

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12290. - Resolution: Fixed > Update tenant module to use parent pom 52 >

Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2049662623 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2049658267 ## [![Quality Gate

[PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (SLING-12290) Update tenant module to use parent pom 52

2024-04-11 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-12290: --- Summary: Update tenant module to use parent pom 52 Key: SLING-12290 URL: https://issues.apache.org/jira/browse/SLING-12290 Project: Sling Issue Type:

[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules

2024-04-11 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836157#comment-17836157 ] Oliver Lietz commented on SLING-10506: -- [~kwin], Makes totally sense to add (I've suppressed the

[jira] [Resolved] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12266. Fix Version/s: Testing Sling Mock Oak 3.2.0-1.44.0 Testing Sling Mock

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
stefanseifert merged PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2049560447 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
stefanseifert commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560922574 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: i've created

Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]

2024-04-11 Thread via GitHub
stefanseifert merged PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies

2024-04-11 Thread Christian Schneider (Jira)
[ https://issues.apache.org/jira/browse/SLING-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12288: Fix Version/s: Content Distribution Journal Core 0.3.0 > Allow configuration of

[jira] [Created] (SLING-12289) PackageStatusWatcher should ignore additional status for the same package

2024-04-11 Thread Christian Schneider (Jira)
Christian Schneider created SLING-12289: --- Summary: PackageStatusWatcher should ignore additional status for the same package Key: SLING-12289 URL: https://issues.apache.org/jira/browse/SLING-12289

[jira] [Created] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies

2024-04-11 Thread Christian Schneider (Jira)
Christian Schneider created SLING-12288: --- Summary: Allow configuration of SubscriberReady forceIdleMillies Key: SLING-12288 URL: https://issues.apache.org/jira/browse/SLING-12288 Project: Sling

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Csaba Varga (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836117#comment-17836117 ] Csaba Varga commented on SLING-12266: - [~sseifert] : Removed the "more aggressive" commit as

[jira] [Resolved] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12285. - Resolution: Fixed > adding bind & unbind methods mapping in reference annotation >

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12285: --- Assignee: Gagan Malpani > adding bind & unbind methods mapping in reference

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Component/s: Extensions (was: General) > adding bind & unbind

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Issue Type: Bug (was: Improvement) > adding bind & unbind methods mapping in reference

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2049255899 Thanks for the PR and explanation in the Jira issue @gagan031992 , I've merged the fix and will create a release this week. -- This is an automated message from the

[jira] [Resolved] (SLING-12286) Tenant build fails with Java 17 or newer

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12286. - Resolution: Fixed > Tenant build fails with Java 17 or newer >

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2049247224 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Created] (SLING-12287) sling-mock-oak: Use latest Oak Version and add ITs to ensure compatiblity with 1.22.x

2024-04-11 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-12287: -- Summary: sling-mock-oak: Use latest Oak Version and add ITs to ensure compatiblity with 1.22.x Key: SLING-12287 URL: https://issues.apache.org/jira/browse/SLING-12287

Re: [PR] SLING-12286 - Tenant build fails with Java 17 or newer [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836072#comment-17836072 ] Julian Reschke commented on SLING-12266: bq. there was some need form other sling modules to

Re: [PR] SLING-12286 - Tenant build fails with Java 17 or newer [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4#issuecomment-2049232427 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Updated] (SLING-12286) Tenant build fails with Java 17 or newer

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12286: Summary: Tenant build fails with Java 17 or newer (was: Tenat build fails with Java 17

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836068#comment-17836068 ] Stefan Seifert commented on SLING-12266: ah, ok. there was some need form other sling modules to

[PR] SLING-12286 - Tenat build fails with Java 17 or newer [sling-org-apache-sling-tenant]

2024-04-11 Thread via GitHub
rombert opened a new pull request, #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4 Update to Mockito 4.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (SLING-12286) Tenat build fails with Java 17 or newer

2024-04-11 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-12286: --- Summary: Tenat build fails with Java 17 or newer Key: SLING-12286 URL: https://issues.apache.org/jira/browse/SLING-12286 Project: Sling Issue Type:

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Fix Version/s: Tenant 1.1.8 > adding bind & unbind methods mapping in reference

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836061#comment-17836061 ] Julian Reschke commented on SLING-12266: Yep - that's an unsupported version. Either use a

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836059#comment-17836059 ] Stefan Seifert commented on SLING-12266: yes - and we should be using that oak 1.22.x version in

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836055#comment-17836055 ] Julian Reschke commented on SLING-12266: AEM 6.5 should be on Oak 1.22.18 with the latest SP. If

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-11 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836054#comment-17836054 ] Stefan Seifert commented on SLING-12266: i tested both PRs locally with the unit tests from

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-11 Thread via GitHub
csaboka commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560500748 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: I think this change would be better done in a separate