[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-20 Thread GitBox
sonarcloud[bot] commented on PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#issuecomment-1398477174 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #29: SLING-11758 expose line and column in RepoInitParsingException

2023-01-20 Thread GitBox
sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/29#issuecomment-1398476889 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-20 Thread GitBox
kwin commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1398274946 @anchela Any chance you can do the review today? I would like to merge and create the releases soon. This issue is lingering for too long already. -- This is an

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #93: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarity

2023-01-20 Thread GitBox
joerghoh merged PR #93: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1397300434 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1397300487 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a diff in pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-19 Thread GitBox
dulvac commented on code in PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#discussion_r1081317327 ## src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java: ## @@ -80,4 +83,41 @@ private boolean

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #93: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarity

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #93: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/93#issuecomment-1396864071 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #93: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarity

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #93: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/93#issuecomment-1396840347 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] reschke opened a new pull request, #93: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarity

2023-01-19 Thread GitBox
reschke opened a new pull request, #93: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/93 … -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [sling-org-apache-sling-resourceresolver] reschke closed pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-19 Thread GitBox
reschke closed pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #92: SLING-11755: resource resolver: improve test coverage for vanity path targets

2023-01-19 Thread GitBox
joerghoh merged PR #92: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #92: SLING-11755: resource resolver: improve test coverage for vanity path targets

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #92: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/92#issuecomment-1387087972 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #92: SLING-11755: resource resolver: improve test coverage for vanity path targets

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #92: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/92#issuecomment-1387037413 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #92: SLING-11755: resource resolver: improve test coverage for vanity path targets

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #92: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/92#issuecomment-1387026739 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-clients] joerghoh commented on a diff in pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-18 Thread GitBox
joerghoh commented on code in PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#discussion_r1073366762 ## src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java: ## @@ -48,14 +50,15 @@ public boolean

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #92: SLING-11755: resource resolver: improve test coverage for vabidy path targets

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #92: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/92#issuecomment-1385894671 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385867134 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385842823 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385823938 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385766029 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
reschke commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385758306 do not merge yet, I'm still testing and will move test case changes somewhere else -- This is an automated message from the Apache Git Service. To respond

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
reschke commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385598545 Yep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [sling-org-apache-sling-resourceresolver] anchela commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
anchela commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385590188 @reschke , it seems that the new ifs from the refactoring are not covered by tests. is this right? -- This is an automated message from the Apache Git

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #91: SLING-11756: resource resolver: rewrite getVanityPathDefinition for more clarify

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #91: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/91#issuecomment-1385571292 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #90: SLING-11755: resource resolver: add test coverage for URL patterns in vanity paths

2023-01-17 Thread GitBox
joerghoh merged PR #90: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on pull request #90: SLING-11755: resource resolver: add test coverage for URL patterns in vanity paths

2023-01-17 Thread GitBox
reschke commented on PR #90: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/90#issuecomment-1385451474 Next I need a Sling committer to merge it :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1384952122 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-base] sonarcloud[bot] commented on pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7#issuecomment-1383951673 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-base] cristic83 opened a new pull request, #7: [SLING-11741] Provide alternative terminology for inequitable terms

2023-01-16 Thread GitBox
cristic83 opened a new pull request, #7: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7 This PR introduces alternative terminology for terms considered un-appropriate. The approach taken was to introduce new configurations named "allowedlist.bypass" and

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1383276019 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #10: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/10#issuecomment-1382896448 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #5: Bump httpclient from 4.3 to 4.5.13

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1382896370 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #7: Bump org.apache.sling.servlets.post from 2.3.0 to 2.3.8

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1382896352 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #8: Bump org.apache.sling.api from 2.3.0 to 2.25.4

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1382896298 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #6: Bump plexus-utils from 3.0.9 to 3.0.16

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #6: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1382896279 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1382635297 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1380989068 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1380924803 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1380914032 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1380772623 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin merged pull request #41: SLING-11736 support new "ensure nodes ..." statement

2023-01-12 Thread GitBox
kwin merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-site] kwin opened a new pull request, #107: SLING-10281 and SLING-11736 document new statements

2023-01-12 Thread GitBox
kwin opened a new pull request, #107: URL: https://github.com/apache/sling-site/pull/107 clarify failure handling deprecate "create path" and "set principal ACL" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#issuecomment-1379997598 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-clients] marcpf commented on a diff in pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-12 Thread GitBox
marcpf commented on code in PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#discussion_r1067849344 ## src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java: ## @@ -80,4 +83,32 @@ private boolean

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #41: SLING-11736 support new "ensure nodes ..." statement

2023-01-11 Thread GitBox
kwin commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1379262990 > create a blocker ticket for the converter to make sure we check this before cutting a new release with the latest repoinit? Done in

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-11 Thread GitBox
kwin commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1379262077 > can you create a ticket (or use the same as for the other parser extensions) to make sure we adjust the converter before cutting any release with the new

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1378818775 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #41: SLING-11736 support new "ensure nodes ..." statement

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1378798100 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#issuecomment-1378783819 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] anchela commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-11 Thread GitBox
anchela commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1378764345 @kwin , i have to catch up with a few other things but will take a look at the PR asap. i don't have the details present any more but it's on my list. one

[GitHub] [sling-org-apache-sling-resourceresolver] cristic83 commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-11 Thread GitBox
cristic83 commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1066964951 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java: ## @@ -79,6 +81,45 @@ private static

[GitHub] [sling-org-apache-sling-resourceresolver] cristic83 commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-11 Thread GitBox
cristic83 commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1066964951 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java: ## @@ -79,6 +81,45 @@ private static

[GitHub] [sling-org-apache-sling-resourceresolver] cristic83 commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-11 Thread GitBox
cristic83 commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1066964951 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java: ## @@ -79,6 +81,45 @@ private static

[GitHub] [sling-org-apache-sling-testing-clients] bdelacretaz commented on a diff in pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-11 Thread GitBox
bdelacretaz commented on code in PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#discussion_r1066948994 ## src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java: ## @@ -80,4 +83,32 @@ private boolean

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin merged pull request #43: build with Windows and on the last 3 Java LTS versions

2023-01-11 Thread GitBox
kwin merged PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-11 Thread GitBox
rombert commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1066899199 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java: ## @@ -163,15 +163,27 @@

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42#issuecomment-1378568112 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #43: build with Windows and on the last 3 Java LTS versions

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/43#issuecomment-1378536534 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] reschke commented on pull request #39: SLING-11621: Update JCR dependencies

2023-01-11 Thread GitBox
reschke commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#issuecomment-1378443481 The issue seems to be caused by those ITs trying to bind to jackrabbit artefacts (like rmi) that are not present with the version number being asked for. I

[GitHub] [sling-org-apache-sling-testing-clients] marcpf opened a new pull request, #42: SLING-11748 - Improve logging output of HTTP retries in testing clients

2023-01-11 Thread GitBox
marcpf opened a new pull request, #42: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42 https://issues.apache.org/jira/browse/SLING-11748 Proposal for improving the HTTP retry log output in the testing clients. Current Output (from unit test):

[GitHub] [sling-site] joerghoh merged pull request #106: SLING-11711 rework of the Sling Model documentation, part 1

2023-01-11 Thread GitBox
joerghoh merged PR #106: URL: https://github.com/apache/sling-site/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-jcr-repoinit] reschke commented on pull request #39: SLING-11621: Update JCR dependencies

2023-01-10 Thread GitBox
reschke commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#issuecomment-1378358483 Ok, will have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #41: SLING-11736 support new "ensure nodes ..." statement

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1378055935 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin merged pull request #42: SLING-11737: jcr-repoinit - fix test failures on Windows

2023-01-10 Thread GitBox
kwin merged PR #42: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 support new "ensure principal ACL" statements

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1377332512 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-10 Thread GitBox
bdelacretaz commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#issuecomment-1377222608 Could you regenerate the "Appendix A" content at https://sling.apache.org/documentation/bundles/repository-initialization.html to include this new

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin merged pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-10 Thread GitBox
kwin merged PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin merged pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-10 Thread GitBox
kwin merged PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#issuecomment-1375931569 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] cristic83 opened a new pull request, #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-01-09 Thread GitBox
cristic83 opened a new pull request, #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89 This PR introduces alternative terminology for terms that are considered un-appropriate for vanity paths, as described in [1]. The approach taken was to provide

[GitHub] [sling-org-apache-sling-testing-rules] joerghoh commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent

2023-01-09 Thread GitBox
joerghoh commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1375737410 works fine here. ``` Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29) Maven home: /opt/homebrew/Cellar/maven/3.8.7/libexec Java version:

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#issuecomment-1375692303 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on a diff in pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-09 Thread GitBox
kwin commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#discussion_r1064688412 ## src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java: ## @@ -27,7 +27,9 @@ /** Set ACL statement that

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #82: Update to o.a.s.feature.launcher 1.2.4

2023-01-09 Thread GitBox
rombert merged PR #82: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-09 Thread GitBox
bdelacretaz commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#issuecomment-1375616340 This refers to https://issues.apache.org/jira/browse/SLING-10281 but I don't see a mention of an "ensure" statement there. Did I miss a discussion that

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on a diff in pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
kwin commented on code in PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#discussion_r1064629244 ## src/main/java/org/apache/sling/repoinit/parser/operations/EnsureNodes.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on a diff in pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-09 Thread GitBox
bdelacretaz commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#discussion_r1064628908 ## src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java: ## @@ -27,7 +27,9 @@ /** Set ACL statement

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on a diff in pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
bdelacretaz commented on code in PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#discussion_r1064627289 ## src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java: ## @@ -223,6 +224,16 @@ public void

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on a diff in pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
bdelacretaz commented on code in PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#discussion_r1064626192 ## src/main/java/org/apache/sling/repoinit/parser/operations/EnsureNodes.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on a diff in pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
bdelacretaz commented on code in PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#discussion_r1064624010 ## src/main/java/org/apache/sling/repoinit/parser/operations/CreatePath.java: ## @@ -25,7 +25,12 @@ import

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics

2023-01-09 Thread GitBox
kwin commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#issuecomment-1375525418 I will merge tomorrow if there are no concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with

2023-01-09 Thread GitBox
kwin commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#issuecomment-1375525024 I will merge tomorrow if there are no concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #27: Bump minimatch from 3.0.4 to 3.1.2 in /ui

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/27#issuecomment-1375068695 Looks like minimatch is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #20: Bump terser from 5.10.0 to 5.14.2 in /ui

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #20: Bump terser from 5.10.0 to 5.14.2 in /ui URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #19: Bump async from 3.2.0 to 3.2.3 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #19: Bump async from 3.2.0 to 3.2.3 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #14: Bump minimist from 1.2.5 to 1.2.6 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #14: Bump minimist from 1.2.5 to 1.2.6 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #18: Bump node-fetch from 2.6.1 to 2.6.7 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #18: Bump node-fetch from 2.6.1 to 2.6.7 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #13: Bump minimist from 1.2.5 to 1.2.6 in /ui

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #13: Bump minimist from 1.2.5 to 1.2.6 in /ui URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #16: Bump ws from 6.2.1 to 6.2.2 in /it

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #16: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/16#issuecomment-1375068629 Looks like ws is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #28: Bump engine.io and socket.io in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #28: Bump engine.io and socket.io in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #27: Bump minimatch from 3.0.4 to 3.1.2 in /ui

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #27: Bump minimatch from 3.0.4 to 3.1.2 in /ui URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #30: Bump qs from 6.5.2 to 6.5.3 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #30: Bump qs from 6.5.2 to 6.5.3 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #30: Bump qs from 6.5.2 to 6.5.3 in /it

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #30: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/30#issuecomment-1375068697 Looks like qs is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #13: Bump minimist from 1.2.5 to 1.2.6 in /ui

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/13#issuecomment-1375068628 Looks like minimist is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #28: Bump engine.io and socket.io in /it

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28#issuecomment-1375068690 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #26: Bump minimatch from 3.0.4 to 3.1.2 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #26: Bump minimatch from 3.0.4 to 3.1.2 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #16: Bump ws from 6.2.1 to 6.2.2 in /it

2023-01-08 Thread GitBox
dependabot[bot] closed pull request #16: Bump ws from 6.2.1 to 6.2.2 in /it URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #26: Bump minimatch from 3.0.4 to 3.1.2 in /it

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/26#issuecomment-1375068660 Looks like minimatch is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #18: Bump node-fetch from 2.6.1 to 2.6.7 in /it

2023-01-08 Thread GitBox
dependabot[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/18#issuecomment-1375068625 Looks like node-fetch is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

  1   2   3   4   5   6   7   8   9   10   >