Re: Cleaning up IntelliJ warnings in code base

2022-05-31 Thread Eric Pugh
Cool. So here is an example of what I’ll merge in a day or so: https://github.com/apache/solr/pull/885 And I’m going to start on a new PR for https://issues.apache.org/jira/browse/SOLR-16224 that is about looking at how fields are defined in the tests. > On May 31, 2022, at 12:41 PM, Hous

Re: Cleaning up IntelliJ warnings in code base

2022-05-31 Thread Houston Putman
> > What about back porting, would you want these back ported to 8 and 9? Or > just 9? > I would say just main and branch_9x On Tue, May 31, 2022 at 12:39 PM Eric Pugh wrote: > Thanks for the response Mike… > > So I finished up going through the test code, and yeah, wow…. Doing it > one file

Re: Cleaning up IntelliJ warnings in code base

2022-05-31 Thread Eric Pugh
Thanks for the response Mike… So I finished up going through the test code, and yeah, wow…. Doing it one file at a time was educational at least ;-). https://github.com/apache/solr/compare/main...epugh:intellij_inspired_cleanups?expand=1 In terms of a workflow, should I open up a single JIRA a

Re: Bugfix release Lucene/Solr 8.11.2

2022-05-31 Thread Mike Drob
Howdy folks, now that Lucene 9.2 has wrapped and we're past the holiday weekend in the United States, I'd like to take a look at getting this rolling by the end of the week. I see an open PR for backporting LUCENE-10236 but it doesn't look like anything else would really be waiting at the moment.