This is a great idea Jason!
As per Jan's suggestion, I think it would be great for the host to pick a
time in their time zone, so that no one feels pressured. There's enough
community members around the globe to not stick to the US
timezones religiously.
- Houston
On Thu, Jan 26, 2023 at 6:12 AM
@Ishan - not necessarily, a committer has to explicitly approve running the
GHA checks for first time contributors. So a random person with a drive-by
PR won't be automatically handed the keys to our infra. I believe we can
set that to needing approval for each run by a non-committer, or maybe
that
Non-committers’ PRs do not have Github Actions run automatically. A
committer has to press a button to allow the tests to run. So unless a
committer is malicious, there shouldnt be a problem there.
On Thu, Jan 26, 2023 at 10:18 AM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:
> Though,
Though, if a malicious user creates a PR that executes harmful code, that
PR will also get executed (via "gradlew test"), right?
On Thu, 26 Jan, 2023, 8:36 pm Yuvraaj Kelkar, wrote:
> Hm. I see your point. The first solution I thought of is a bit blunt, but
> it will work: We disable command lin
Hm. I see your point. The first solution I thought of is a bit blunt, but it
will work: We disable command line arguments when using ZeroConf. Only preset
commands are allowed.
Also, to allow the Solr GHA to run whatever commands needed not just for now,
but also for any future changes, we set u
Having massive infrastructure to run PRs is pretty cool.
I'm worried about letting arbitrary people run code on these
machines though - a single 'crave run -- mine_bitcoin.exe' would ruin the
system for everybody, or it's not hard to imagine a slightly more indirect
case where an attacker adds a t
Yes, the stdout and stderr are streamed back to the initiator - the Github
runner - which then records it as part of the Actions' logs.
On Jan 26 2023, at 5:11 am, Eric Pugh wrote:
> Running the tests on every PR raised will make reviewing patches MUCH
> simpler. Today, on my laptop, it’s 40 mi
I like this.
Perhaps it will also put more focus on fixing bad tests, since some PRs are
bound to fail the full test suite due to test flakiness, but it will be more
evident. Which is a good thing.
Jan
> 26. jan. 2023 kl. 12:11 skrev Eric Pugh :
>
> Running the tests on every PR raised will
+1 Let’s do it.
> On Jan 24, 2023, at 11:24 AM, David Smiley wrote:
>
> We already have a precedent of using Confluence for meeting notes. Here's
> the last one:
> https://cwiki.apache.org/confluence/display/SOLR/2022-05-10+Meeting+notes
>
> An email that occurs per meeting would be good to re
Running the tests on every PR raised will make reviewing patches MUCH simpler.
Today, on my laptop, it’s 40 minutes to 1 hour to run the full process, and I
can’t use my machine during that time..Being able to look at a PR and see
that the tests run will make me more likely to review ;-).
10 matches
Mail list logo
