[RESULT] [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Gus Heck
It's been >72h since the vote was initiated and the result is: +1 7 (6 binding) 0 0 -1 0 This vote has PASSED

Re: [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Gus Heck
I agree with Chris's assessment, and so I'm not tallying the vote... On Fri, Apr 26, 2024 at 1:49 PM Chris Hostetter wrote: > > : Reproduced on my machine too, but it's a timeAllowed test that relies on > : timeAllowed=0 which is arguably a degenerate setting, OTOH it did start > : failing in ma

Re: Tracking contributors uniquely

2024-04-26 Thread Chris Hostetter
: LOL meanwhile I posted https://github.com/apache/solr/pull/2424 for : the script I developed and improved today. : I think CHANGES.txt is the best source for a release centric view : while git log is best for project health metrics. Agreed. People are frequently mentioned in CHANGES because th

Re: Tracking contributors uniquely

2024-04-26 Thread David Smiley
LOL meanwhile I posted https://github.com/apache/solr/pull/2424 for the script I developed and improved today. I think CHANGES.txt is the best source for a release centric view while git log is best for project health metrics. On Fri, Apr 26, 2024 at 4:38 PM Jan Høydahl wrote: > > I think it is a

Re: Tracking contributors uniquely

2024-04-26 Thread Andy Lester
> The changelog has the names. Repeating it in the release announcement mail > feels redundant to me. Being redundant in this case is not a problem. The DRY principle applies to code, not expressions of gratitude. Names are included to honor and thank the people who have helped. The point is n

Re: Ideas for release notes for 9.6

2024-04-26 Thread David Smiley
I added a "Thanks to all contributors" section at the end based on the 9.6 CHANGES.txt. On Mon, Apr 22, 2024 at 10:48 PM Gus Heck wrote: > > Initial release notes have been drafted here, please flesh out, refine, > copy edit as needed. > > https://cwiki.apache.org/confluence/display/SOLR/ReleaseN

Re: Tracking contributors uniquely

2024-04-26 Thread Jan Høydahl
I think it is a good idea to include a list of contributors in the release note mail. it is a tiny encouragement for folks to contribute more. The list should perhaps be excluding committers, so we only list external contributors? I already added a script to dev-tools to parse SolrBot contributio

Re: Tracking contributors uniquely

2024-04-26 Thread Ishan Chattopadhyaya
The changelog has the names. Repeating it in the release announcement mail feels redundant to me. On Fri, 26 Apr, 2024, 11:07 pm Andy Lester, wrote: > > > The context of the name appearing as I propose in a "thank you" is > > merely to thank them, not to indirectly hold them to stability/quality

Re: [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Chris Hostetter
: Reproduced on my machine too, but it's a timeAllowed test that relies on : timeAllowed=0 which is arguably a degenerate setting, OTOH it did start : failing in march, and timeAllowed/Limits are something touched in this : release. TL;DR: This is just a blatently bad test, and doesn't seem to in

Re: Tracking contributors uniquely

2024-04-26 Thread Andy Lester
> The context of the name appearing as I propose in a "thank you" is > merely to thank them, not to indirectly hold them to stability/quality > measures. I heartily endorse listing everyone who did something on a release. It drives me crazy every time there is a release of GCC that ends with t

Re: [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Gus Heck
I'm going to investigate the failure Michael found, but due to existing commitments I'm unlikely to have time for it until tomorrow. Are folks ok with me holding this vote in limbo? Technically nobody has voted against yet (though I'm on the fence vs changing my vote pending my investigation) so if

Re: Tracking contributors uniquely

2024-04-26 Thread Eric Pugh
I like it! > On Apr 26, 2024, at 9:39 AM, David Smiley wrote: > > On Fri, Apr 26, 2024 at 9:35 AM Gus Heck wrote: >> >> I don't know if it's relevant, but I recall that back in the early 2000's >> around the time of the adoption of the ASL 2.0 (when I was contributing to >> Ant) the ASF had us

Re: [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Gus Heck
Reproduced on my machine too, but it's a timeAllowed test that relies on timeAllowed=0 which is arguably a degenerate setting, OTOH it did start failing in march, and timeAllowed/Limits are something touched in this release. https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.ro

Re: Tracking contributors uniquely

2024-04-26 Thread David Smiley
On Fri, Apr 26, 2024 at 9:35 AM Gus Heck wrote: > > I don't know if it's relevant, but I recall that back in the early 2000's > around the time of the adoption of the ASL 2.0 (when I was contributing to > Ant) the ASF had us stop using @author tags in code. I was not a fan at the > time, but they

Re: Tracking contributors uniquely

2024-04-26 Thread Gus Heck
I don't know if it's relevant, but I recall that back in the early 2000's around the time of the adoption of the ASL 2.0 (when I was contributing to Ant) the ASF had us stop using @author tags in code. I was not a fan at the time, but they had some reason I don't fully recall relating to shielding

Re: [VOTE] Release Solr 9.6.0 RC1

2024-04-26 Thread Michael Gibney
I got a test failure that reproduces for me locally: gradlew :solr:modules:analytics:test --tests "org.apache.solr.analytics.legacy.facet.LegacyFieldFacetTest.timeAllowedTest" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCach