Re: PRS, important changes needed

2024-05-03 Thread Justin Sweeney
default". > > > > I don't know if this thread is the best place to discuss it but having > > the PRS znode be ephemeral would be really beneficial to dramatically > > strengthen the goals of PRS by efficiently handling restarts. No need > > to mark a node's replicas

Re: PRS, important changes needed

2024-05-02 Thread Justin Sweeney
We (Fullstory) have been running PRS for quite a while now with great stability and a huge performance benefit for us particularly in terms of cluster restarts. That said, our use case certainly isn't everyone's use case. We run large clusters with lots of cores so we get a particular benefit. My

Re: Compressing state.json being used in ZkCLI.java?

2024-03-05 Thread Justin Sweeney
? > > Thanks for looking at this! > > > > > On Feb 29, 2024, at 12:29 PM, Justin Sweeney > wrote: > > > > I actually think that use case should just work since the SolrZkClient > can > > already handle compressed state.json, assuming you are just using the >

Re: Compressing state.json being used in ZkCLI.java?

2024-02-29 Thread Justin Sweeney
I actually think that use case should just work since the SolrZkClient can already handle compressed state.json, assuming you are just using the default ZLib implementation of compression. When getting data it looks like the ZkCpTool calls SolrZkClient.getData() which is able to check if the data

Re: Change suggestion: more efficient replica state tracking

2023-09-28 Thread Justin Sweeney
o I don't know if it's related to local changes (we run a fork of upstream > SolrCloud) or if it's a general problem. > In any case, if PRS is modified to use EPHEMERAL ZK nodes, indeed ZK > session expiration is something to be careful with. > > Ilan > > On Wed, Sep 27, 2023

Re: Change suggestion: more efficient replica state tracking

2023-09-26 Thread Justin Sweeney
Hey Ilan, curious if you have tried PRS in your implementation or not at this point and what your experience has been if you have tried it? I believe PRS currently publishes DOWNNODE messages to overseer, but they are essentially a no-op by the overseer so they have very little impact. We are

Re: [DISCUSS] SIP-19 Adopt JSR-330 dependency injection

2023-09-26 Thread Justin Sweeney
+1 on this SIP and a POC would make sense. I think it could be valuable to update the Motivation section with the anticipated value provided by this SIP, i.e. reduced code maintenance, removing brittle home-grown interfaces, etc. Most of my IOC/DI experience is with Spring and Dagger seems like a

Re: Welcome Alex Deparvu as Solr committer

2023-08-02 Thread Justin Sweeney
Congrats Alex and welcome! On Wed, Aug 2, 2023 at 8:59 AM Eric Pugh wrote: > > Awesome Alex! Really enjoyed working with you so far…. > > > On Aug 2, 2023, at 8:54 AM, Mike Drob wrote: > > > > Welcome and congratulations! > > > > On Wed, Aug 2, 2023 at 8:47 AM David Smiley > > wrote: > > > >>

[ANNOUNCE] Apache Solr 9.2.1 released

2023-05-01 Thread Justin Sweeney
The Solr PMC is pleased to announce the release of Apache Solr 9.2.1. Solr is the popular, blazing fast, open source NoSQL search platform from the Apache Solr project. Its major features include powerful full-text search, hit highlighting, faceted search, dynamic clustering, database

[RESULT] [VOTE] Release Solr 9.2.1 RC1

2023-05-01 Thread Justin Sweeney
It's been >72h since the vote was initiated and the result is: +1 6 (5 binding) 0 0 -1 0 This vote has PASSED

Re: [VOTE] Release Solr 9.2.1 RC1

2023-04-29 Thread Justin Sweeney
as the proposed change that > >>>> Ishan > >>>> speaks of is an "improvement" that helps security and is not a > >>>> bug/vulnerability being fixed. It would also bring a backwards > >>>> compatibility change. So please do continue with this long

Re: SolrCloud separating compute from storage

2023-04-28 Thread Justin Sweeney
This definitely sounds very interesting and if we could abstract it away from AWS specifically then even better. I think there are a lot of advantages with an approach like this as you've mentioned. At FullStory we are planning to get into some experiments using GCP Local SSDs and Google Cloud

Re: [VOTE] Release Solr 9.2.1 RC1

2023-04-28 Thread Justin Sweeney
> Joel Bernstein > > > http://joelsolr.blogspot.com/ > > > > > > > > > On Thu, Apr 27, 2023 at 1:23 PM Jan Høydahl > > wrote: > > > > > > > +1 (binding) > > > > > > > > SUCCESS! [0:38:44.920838] > >

Re: [VOTE] Release Solr 9.2.1 RC1

2023-04-27 Thread Justin Sweeney
ast 72 hours i.e. until 2023-04-30 15:00 UTC. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) On Mon, Apr 24, 2023 at 12:38 PM Justin Sweeney wrote: > Yup, let's wait in that case. I didn't realize it would fail since I had > temporarily added my key locally to be able to

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-26 Thread Justin Sweeney
Yup, I commented on the ticket. I was able to push today. I’ll update the release vote thread in the morning. On Wed, Apr 26, 2023 at 6:35 PM Jan Høydahl wrote: > I believe it should be fixed now? > > Jan Høydahl > > > 26. apr. 2023 kl. 15:32 skrev Justin Sweeney >

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-26 Thread Justin Sweeney
slack. > If this is not unblocked by tonight, I'm happy to commit your public key > for you, I see your key ID 7AA80271 in > https://people.apache.org/keys/committer/ > > Jan > > > 26. apr. 2023 kl. 14:53 skrev Justin Sweeney >: > > > > Looks like > https://is

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-26 Thread Justin Sweeney
gt; > > > Jan > > > > > > > > > > > 21. apr. 2023 kl. 01:01 skrev Ishan Chattopadhyaya < > > > > > ichattopadhy...@gmail.com>: > > > > > > > > > > > > Vote and 3 days of wait!? This whole Apache proc

Re: [VOTE] Release Solr 9.2.1 RC1

2023-04-24 Thread Justin Sweeney
wrote: > Hey Justin, > > Should we wait to run this until after your GPG key is in > https://downloads.apache.org/solr/KEYS? > > The smoketester fails for me because it can't find your key. > > - Houston > > On Mon, Apr 24, 2023 at 12:20 PM Justin Sweeney < >

[VOTE] Release Solr 9.2.1 RC1

2023-04-24 Thread Justin Sweeney
Please vote for release candidate 1 for Solr 9.2.1 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/solr/solr-9.2.1-RC1-rev-a4c64ab6a2a270ca69c28c706dabb2927ed8a7c2 You can run the smoke tester directly with this command: python3 -u

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-21 Thread Justin Sweeney
sensible thing. > > > > On Fri, 21 Apr, 2023, 7:56 pm Justin Sweeney, < > justin.sweene...@gmail.com> > > wrote: > > > >> Just to close the loop on this, should I kick off a vote as a new > thread to > >> the dev group or should that be kicked

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-21 Thread Justin Sweeney
wentieth century. If such a vote is a strict > > > necessity, I think we should also get a vote on whether to stick with > > > Apache. > > > > > > On Fri, 21 Apr, 2023, 3:52 am Justin Sweeney, < > > justin.sweene...@gmail.com> > > > wrote: &g

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-20 Thread Justin Sweeney
t allow it, so Solr doesn't have it > > enabled now. > > > > As per the JIRA infra can do this. Should we get a PMC vote on this? > > > > - Houston > > > > On Thu, Apr 20, 2023 at 4:06 PM Houston Putman > wrote: > > > >> I commented. >

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-20 Thread Justin Sweeney
re, so I’d just proceed with the release > and > >> ask again if it becomes a problem. Non-pmc committers have certainly > been > >> RM before. > >> > >> Jan Høydahl > >> > >>> 20. apr. 2023 kl. 17:19 skrev Justin Sweeney < > justin.swee

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-20 Thread Justin Sweeney
can open an Infra ticket to change permissions, but it will likely require some approvals beyond myself. Justin On Thu, Apr 20, 2023 at 10:21 AM Justin Sweeney wrote: > Yup, feel free to go ahead and merge that in. > > On Thu, Apr 20, 2023 at 10:18 AM Ishan Chattopadhyaya < &g

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-20 Thread Justin Sweeney
Ishan > > On Thu, 20 Apr 2023 at 19:37, Justin Sweeney > wrote: > > > Thanks for merging that, I'm just getting started along the release > > process, had to get a gpg key setup but should be moving today. > > > > On Wed, Apr 19, 2023 at 11:03 AM Jan Høydahl &g

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-20 Thread Justin Sweeney
's a good one to include. > > > > - Houston > > > > On Wed, Apr 19, 2023 at 7:37 AM Jan Høydahl > wrote: > > > >> Is there still time to back-port > >> https://issues.apache.org/jira/browse/SOLR-16755 ? > >> > >&g

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-12 Thread Justin Sweeney
e release. There are > initial steps that are meant to be done days before the release is created. > > There will be two particular snags since you aren't a PMC member, but they > will come up early and the releaseWizard will prompt you to address them. > > If you have any questions

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-12 Thread Justin Sweeney
+1 If you need a volunteer to execute the release, I can volunteer to do that next week. Are there docs available for the release process as it'd be my first time through? Justin On Tue, Apr 11, 2023 at 12:10 PM Jan Høydahl wrote: > +1 > > Jan > > > 11. apr. 2023 kl. 15:51 skrev Houston Putman

Re: Welcome Marcus Eagan as Solr committer

2023-04-02 Thread Justin Sweeney
Congratulations Marcus! On Sun, Apr 2, 2023 at 12:48 PM Gus Heck wrote: > Congratulations and Welcome! > > On Sun, Apr 2, 2023 at 10:54 AM Mikhail Khludnev wrote: > > > Welcome, Marcus! > > > > On Sun, Apr 2, 2023 at 7:31 AM Marcus Eagan > wrote: > > > > > Thanks everyone! > > > > > > Bio

Re: Welcome David Smiley as Solr's new PMC chair

2023-03-31 Thread Justin Sweeney
Congrats David, well deserved! On Fri, Mar 31, 2023 at 1:05 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Congrats David! > > On Fri, 31 Mar 2023 at 22:34, Houston Putman wrote: > > > Hello, > > > > Solr has had quite a year, with a major release and many cool new > >

Re: Google Java Style: shall we declare intent to follow?

2023-03-15 Thread Justin Sweeney
t; > >>> ichattopadhy...@gmail.com> wrote: > >>> > >>>> My biggest concern with widespread code changes, like the effort to > >> format > >>>> the entire codebase or to suppress warnings etc in the past, is that > >>>> r

Re: Google Java Style: shall we declare intent to follow?

2023-03-08 Thread Justin Sweeney
+1 If we do so, I'd suggest we also add that to the Contributing docs somewhere so it is readily apparent for new contributors: https://github.com/apache/solr/blob/main/CONTRIBUTING.md. On Wed, Mar 8, 2023 at 3:29 AM Bruno Roustant wrote: > +1 > I find that a standard is more productive because

Re: Welcome Andy Webb as Solr committer

2023-03-06 Thread Justin Sweeney
Welcome Andy! On Mon, Mar 6, 2023 at 11:05 AM Houston Putman wrote: > Welcome Andy! > > - Houston > > On Mon, Mar 6, 2023 at 7:31 AM Jason Gerlowski > wrote: > > > Welcome Andy, and congratulations! > > > > On Mon, Mar 6, 2023 at 6:16 AM Jan Høydahl > wrote: > > > > > > Hi all, > > > > > >

Re: Welcome Colvin Cowie as Solr committer

2023-02-14 Thread Justin Sweeney
Welcome Colvin! On Tue, Feb 14, 2023 at 6:27 AM Alessandro Benedetti wrote: > Welcome on board Colvin! > -- > *Alessandro Benedetti* > Director @ Sease Ltd. > *Apache Lucene/Solr Committer* > *Apache Solr PMC Member* > > e-mail: a.benede...@sease.io > > > *Sease* -

Re: Welcome Justin Sweeney as Solr committer

2023-02-10 Thread Justin Sweeney
. Justin On Fri, Feb 10, 2023 at 2:00 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Hi all, > > I'm pleased to announce that Justin Sweeney has accepted the PMC's > invitation to become a committer. > > Justin, the tradition is that new committers introduce t

Re: Recurring (Virtual) Community "Meetups"

2023-01-23 Thread Justin Sweeney
Personally I think this would be great, it'd be nice to connect with others in the community and hear more about pain points, new ideas, etc. One suggestion is it might be useful to have a running Google Doc that people can add items into for discussion at future meetings. This could help provide

Refactoring ZkStateReader

2022-12-30 Thread Justin Sweeney
Hi all, ZkStateReader ( https://github.com/apache/solr/blob/main/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java) is a complicated class with thousands of lines and numerous inner classes. This makes approaching this class overly complex. I was recently investigating

Re: Focusing on single implementations of core logic

2022-09-21 Thread Justin Sweeney
Hey all, I'm a long time Solr user/developer, but only recently joined the dev mailing list for Solr so it is a pleasure to interact with you all. We, at FullStory, working with Ishan and Noble, sponsored the Per Replica State implementation and are using it currently. We are running large