https://github.com/apache/solr/pull/2196
~ David
On Wed, Sep 6, 2023 at 11:17 PM David Smiley
wrote:
> Honestly, I would prefer to do away with it entirely. Dubious logic that
> has been made to only output a warning will continue to be a part of the
> code weight of our sprawling build. It
Honestly, I would prefer to do away with it entirely. Dubious logic that
has been made to only output a warning will continue to be a part of the
code weight of our sprawling build. It will need to be maintained[1]. It
needs to do it's calculations on every check/precommit. I don't even want
Something like this could work?:
https://github.com/apache/solr/blob/eaaabbfa33456639613a7a6aecc37cd2d89e5dfa/gradle/globals.gradle#L168-L171
On Wed, Sep 6, 2023 at 5:26 PM David Smiley wrote:
>
> Is there a property or something used to detect that the build is being run
> in a CI or CI-like
Is there a property or something used to detect that the build is being run
in a CI or CI-like env?
~ David
On Wed, Sep 6, 2023 at 4:50 PM Shawn Heisey wrote:
> On 9/6/23 13:21, Uwe Schindler wrote:
> > The idea is that jenkins runs it after the builds to figure out if
> > something changed in
It’s bit me plenty of times as well…. I like the idea of it not being enabled
by default.
> On Sep 6, 2023, at 4:49 PM, Shawn Heisey wrote:
>
> On 9/6/23 13:21, Uwe Schindler wrote:
>> The idea is that jenkins runs it after the builds to figure out if something
>> changed in the working
On 9/6/23 13:21, Uwe Schindler wrote:
The idea is that jenkins runs it after the builds to figure out if
something changed in the working copy. At ANT times this was implemented
exactly like this, we failed build on Jenkins when the working copy
changed. This was especially important before we
On 9/6/23 10:43, David Smiley wrote:
Our build, inherited from Lucene, contains a custom validation check
"checkWorkingCopyClean" which can be disabled with
"validation.git.failOnModified=false" in your gradle.properties. I always
set this; the concept of failOnModifies seems dubious to me; it
+1 to flipping the default for 'failOnModified'.
On Wed, Sep 6, 2023 at 3:21 PM Uwe Schindler wrote:
>
> The idea is that jenkins runs it after the builds to figure out if
> something changed in the working copy. At ANT times this was implemented
> exactly like this, we failed build on Jenkins
The idea is that jenkins runs it after the builds to figure out if
something changed in the working copy. At ANT times this was implemented
exactly like this, we failed build on Jenkins when the working copy
changed. This was especially important before we used SecurityManager to
prevent tests
Our build, inherited from Lucene, contains a custom validation check
"checkWorkingCopyClean" which can be disabled with
"validation.git.failOnModified=false" in your gradle.properties. I always
set this; the concept of failOnModifies seems dubious to me; it annoys me.
Can an advocate of this
10 matches
Mail list logo
