RE: Re: Unuseful block of code in ltr module

2021-12-22 Thread Christine Poerschke (BLOOMBERG/ LONDON)
behaviour that would happen if some non-ReRankCollector collector called the rescore method in a different way. Hope that helps. Christine From: dev@solr.apache.org At: 12/03/21 15:24:23 UTCTo: dev@solr.apache.org Subject: RE: Re: Unuseful block of code in ltr module Hi Diego, Thank you for your

Re: Re: Unuseful block of code in ltr module

2021-12-03 Thread Alessandro Benedetti
adding in the loop Diego and Christine as potentially they are not in the list yet. -- Alessandro Benedetti Apache Lucene/Solr Committer Director, R&D Software Engineer, Search Consultant www.sease.io On Fri, 3 Dec 2021 at 15:24, Anna Ruggero wrote: > Hi Diego, > Thank

RE: Re: Unuseful block of code in ltr module

2021-12-03 Thread Anna Ruggero
Hi Diego, Thank you for your reply. >From what I've seen the topN variable takes the value from the rerankDocs parameter passed at query time. I've tried to pass different values for the rerankDocs and topN seems always to reflect this. Also in these cases, hits.length was always equal to topN. It

Re: Unuseful block of code in ltr module

2021-12-02 Thread Diego Ceccarelli
Hi, I had a quick look and it seems that Anna is right, but there should be a case where you ask to rerank more documents than what you want to see.. need to review the code :) cheers, Diego On Thu, 2 Dec 2021, 16:40 Alessandro Benedetti, wrote: > Adding Christine and Diego to the loop if th

Re: Unuseful block of code in ltr module

2021-12-02 Thread Alessandro Benedetti
Adding Christine and Diego to the loop if they missed this. Thanks Anna for raising. Cheers -- Alessandro Benedetti Apache Lucene/Solr Committer Director, R&D Software Engineer, Search Consultant www.sease.io On Wed, 10 Nov 2021 at 16:41, Anna Ruggero wrote: > Hi all,

Unuseful block of code in ltr module

2021-11-10 Thread Anna Ruggero
Hi all, I was looking at the *org.apache.solr.ltr.LTRRescorer#scoreFeatures *method. Since we are using reranking applied to some topN documents (rerankDocs parameter) I think that this block of code in *org.apache.solr.ltr.LTRRescorer#scoreSingleHit *will never be accessed: if (hitUpto >= topN)