[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #23 from Henrik Krohns 2010-01-05 23:30:25 UTC --- sure +1 Though I don't get the value of split(' '), since all the others use /\s+/.. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email

[Bug 6274] Semantics of CONF_TYPE_* constants and additional config argument types

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6274 Mark Martinec changed: What|Removed |Added Target Milestone|Undefined |3.3.0 -- Configure bugmail: h

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #22 from Mark Martinec 2010-01-05 16:05:36 UTC --- (In reply to comment #21) > +1 on the changes in comment #17 > > I think the question of config types and the leakage test can be in a new bug > report, allowing us to clos

[Bug 6274] New: Semantics of CONF_TYPE_* constants and additional config argument types

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6274 Summary: Semantics of CONF_TYPE_* constants and additional config argument types Product: Spamassassin Version: 3.3.0 Platform: All OS/Version: All Status:

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #21 from Sidney Markowitz 2010-01-05 14:51:25 UTC --- +1 on the changes in comment #17 I think the question of config types and the leakage test can be in a new bug report, allowing us to close this one again, after we get

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #20 from Sidney Markowitz 2010-01-05 13:32:42 UTC --- (in reply to comment #18) Looking over the test code I think the type would have to indicate the internal representation. In order to read in the config file we have to

[Bug 5590] Scantime is very long unless "use bytes" hack is used

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5590 Matt Selsky changed: What|Removed |Added CC||sel...@columbia.edu -- Configure

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Mark Martinec changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIX

[Bug 6155] generate new scores for 3.3.0 release

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6155 --- Comment #185 from Henrik Krohns 2010-01-05 10:47:51 UTC --- I have a hunch that FREEMAIL_ENVFROM_END_DIGIT has a bit too high score (1.553). Probably there wasn't enough "nicedude90" ham in corpora. Strangely FREEMAIL_REPLYTO_END_DI

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #18 from Mark Martinec 2010-01-05 10:03:54 UTC --- (In reply to comment #16) > I didn't look into the cause and it could very well have been my mistake when > changing things to test it, but this is what I got when I declare

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #17 from Mark Martinec 2010-01-05 09:43:27 UTC --- Created an attachment (id=4620) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4620) Suggested additional patch Some documentation change, one simplificatio

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #16 from Sidney Markowitz 2010-01-05 09:31:07 UTC --- (in reply to comment #15) I didn't look into the cause and it could very well have been my mistake when changing things to test it, but this is what I got when I declare

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #15 from Mark Martinec 2010-01-05 08:37:32 UTC --- (In reply to comment #11) > I tried adding type => $CONF_TYPE_STRING, to originating_ip_headers but it > doesn't work because originating_ip_headers takes an array of string

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #14 from Henrik Krohns 2010-01-05 08:23:17 UTC --- (In reply to comment #13) > > So if I understand this right unless you specify > "clear_originating_ip_headers" > in your local.cf file you will get the default headers plus

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 William Taylor changed: What|Removed |Added CC||willi...@sonic.net --- Comment

SAY2K10 post-mortem

2010-01-05 Thread Justin Mason
hey -- after the Jan 1 thing, I wrote up a blog post of my thoughts: http://taint.org/2010/01/04/003841a.html -- the key bit: > Personally, I see a few lessons from this: > > - Obviously, I need to pay more attention. This is easier said than done > though, since SpamAssassin has nothing to do wi

[Bug 6268] SA die()s if can't create the userstate dir

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6268 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@pccc.com --- Commen

[Bug 6268] SA die()s if can't create the userstate dir

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6268 --- Comment #2 from Justin Mason 2010-01-05 07:31:08 UTC --- Created an attachment (id=4619) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4619) possible fix MD folks -- does this help? -- Configure bugmail: https://

[Bug 6268] SA die()s if can't create the userstate dir

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6268 --- Comment #1 from Justin Mason 2010-01-05 07:29:45 UTC --- (In reply to comment #0) > I'm unsure if the change to a die for the lack of a user_dir was intentional. > So anyone know if/why/etc? it was not, I think. here's the specific

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Henrik Krohns changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #11 from Sidney Markowitz 2010-01-05 06:01:20 UTC --- (in reply to comment 10) I tried adding type => $CONF_TYPE_STRING, to originating_ip_headers but it doesn't work because originating_ip_headers takes an array of strings

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #10 from Mark Martinec 2010-01-05 05:21:24 UTC --- (In reply to comment #8) > It looks like originating_ip_headers and clear_originating_ip_headers have to > be added to the list in t/cross_user_config_leak.t just like trust

[Bug 6263] sa_compile.t test fails if installed re2c version is too old

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6263 Justin Mason changed: What|Removed |Added CC||j...@jmason.org Summa

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Justin Mason changed: What|Removed |Added CC||j...@jmason.org Status Whiteboa

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #8 from Sidney Markowitz 2010-01-05 03:12:04 UTC --- Reading it over, it all looks good. I'm still running tests. It looks like originating_ip_headers and clear_originating_ip_headers have to be added to the list in t/cross

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Henrik Krohns changed: What|Removed |Added Priority|P5 |P1 -- Configure bugmail: http

[Bug 5895] [review] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Henrik Krohns changed: What|Removed |Added Summary|Configurable Originating|[review] Configurable

[Bug 5895] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 Henrik Krohns changed: What|Removed |Added Attachment #4308|0 |1 is obsolete|

[Bug 5895] Configurable Originating Headers for RBL

2010-01-05 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895 --- Comment #6 from Sidney Markowitz 2010-01-05 00:23:41 UTC --- (in reply to comment 5) > Seems I remembered wrong. The headers are only processed rbl lookups I was following you and agreeing until I saw that. I don't understand what