Re: svn commit: r1900514 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm

2022-05-03 Thread Henrik K
FYI I will clean up the whole plugin today. Including fixing the DKIM dependency which would randomly work. If someone wants to work on creating tests for the plugin, that would be helpful.. On Tue, May 03, 2022 at 06:21:38PM +0300, Henrik K wrote: > > For example just above the added defined

Re: svn commit: r1900514 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm

2022-05-03 Thread Henrik K
For example just above the added defined checks is this.. what's the point of checking some defines later, as this would croak anyway.. if ($fnd{'owner'} ne $fad{'owner'}) { $pms->{fromname_owner_different} = 1; } On Tue, May 03, 2022 at 06:08:23PM +0300, Henrik K wrote: > > I really

Re: svn commit: r1900514 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm

2022-05-03 Thread Henrik K
I really dislike these kinds of "band-aids" which really don't help the main cause: terribly convoluted plugin code. Why skip debug output if owner is missing? Is the a good reason for owner missing, what is the cause for that and can it be better fixed upstream? Why are there all kinds of reg

[Bug 7982] make test failures running from 4.0.0 install package

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982 --- Comment #27 from Sidney Markowitz --- (In reply to Henrik Krohns from comment #26) > Ok there's now a function to clear out any external rules. It needed the add_header all Status line that is in 01_test_rules.cf, but after that one add

[Bug 7984] FromNameSpoof uninitialized value $owner

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7984 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it Resolu

[Bug 7662] sa-update outputs an error if a mirror download fails

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7662 --- Comment #7 from Henrik Krohns --- (In reply to Hans Müller from comment #6) > I solved it as described HERE: > -> > https://talk.plesk.com/threads/spam-assassin-60sa-update-exited-with-return- > code-2.364407/#post-907122 > > > With ki

[Bug 7662] sa-update outputs an error if a mirror download fails

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7662 Hans Müller changed: What|Removed |Added CC||jan.ma...@gmx.net --- Comment #6 from

[Bug 7982] make test failures running from 4.0.0 install package

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982 --- Comment #26 from Henrik Krohns --- Ok there's now a function to clear out any external rules. sql_based*.t are completely self sufficient. Except for 20_aux_tlds.cf to not complain about missing tlds.. Sendingt/SATest.pm Sendin

[Bug 7985] DecodeShortURLs errors when multiple shortened urls in message

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7985 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com St

Re: svn commit: r1900506 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DecodeShortURLs.pm

2022-05-03 Thread Henrik K
IMO this is plain wrong. What happens when you encounter the same URL every day? It will never get updated. If the redirection has changed from the provider (for example it was detected as spam, and redirect removed etc), cache will never update to new URL if you see it every day. If you want

[Bug 7985] New: DecodeShortURLs errors when multiple shortened urls in message

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7985 Bug ID: 7985 Summary: DecodeShortURLs errors when multiple shortened urls in message Product: Spamassassin Version: 4.0.0 Hardware: All OS: All

REMINDER - Travel Assistance available for ApacheCon NA New Orleans 2022

2022-05-03 Thread Gavin McDonald
Hi All Contributors and Committers, This is a first reminder email that travel assistance applications for ApacheCon NA 2022 are now open! We will be supporting ApacheCon North America in New Orleans, Louisiana, on October 3rd through 6th, 2022. TAC exists to help those that would like to attend

[Bug 7984] FromNameSpoof uninitialized value $owner

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7984 Matus UHLAR - fantomas changed: What|Removed |Added CC||uh...@fantomas.sk --- Comm

[Bug 7984] New: FromNameSpoof uninitialized value $owner

2022-05-03 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7984 Bug ID: 7984 Summary: FromNameSpoof uninitialized value $owner Product: Spamassassin Version: unspecified Hardware: PC OS: Linux Status: NEW Severity