Re: [build system] jenkins wedged again, rebooting master node

2019-03-15 Thread Sean Owen
It's not responding again. Is there any way to kick it harder? I know it's well understood but this means not much can be merged in Spark On Fri, Mar 15, 2019 at 12:08 PM shane knapp wrote: > > well, that box rebooted in record time! we're back up and building. > > and as always, i'll keep a

Re: Scala type checking thread-safety issue, and global locks to resolve it

2019-03-15 Thread Shixiong(Ryan) Zhu
Forgot to link the ticket that removed the global ScalaReflectionLock: https://issues.apache.org/jira/browse/SPARK-19810 Best Regards, Ryan On Fri, Mar 15, 2019 at 10:40 AM Shixiong(Ryan) Zhu wrote: > Hey Sean, > > Sounds good to me. At least, it's not worse than any versions prior to > 2.3.0

Re: Scala type checking thread-safety issue, and global locks to resolve it

2019-03-15 Thread Shixiong(Ryan) Zhu
Hey Sean, Sounds good to me. At least, it's not worse than any versions prior to 2.3.0 which has a global ScalaReflectionLock. In addition, if someone hits a performance regression caused by this, they probably are creating too many Encoders. Reusing Encoders is a better solution for this case.

Re: [build system] jenkins wedged again, rebooting master node

2019-03-15 Thread Wenchen Fan
cool, thanks! On Sat, Mar 16, 2019 at 1:08 AM shane knapp wrote: > well, that box rebooted in record time! we're back up and building. > > and as always, i'll keep a close eye on things today... jenkins usually > works great, until it doesn't. :\ > > On Fri, Mar 15, 2019 at 9:52 AM shane

Re: [build system] jenkins wedged again, rebooting master node

2019-03-15 Thread shane knapp
well, that box rebooted in record time! we're back up and building. and as always, i'll keep a close eye on things today... jenkins usually works great, until it doesn't. :\ On Fri, Mar 15, 2019 at 9:52 AM shane knapp wrote: > as some of you may have noticed, jenkins got itself in a bad

[build system] jenkins wedged again, rebooting master node

2019-03-15 Thread shane knapp
as some of you may have noticed, jenkins got itself in a bad state multiple times over the past couple of weeks. usually restarting the service is sufficient, but it appears that i need to hit it w/the reboot hammer. jenkins will be down for the next 20-30 minutes as the node reboots and jenkins

Re: PR process

2019-03-15 Thread Sean Owen
Your best bet is to try to ping people who wrote the code that is changing. Jose have you looked at this part, or Cody? On Fri, Mar 15, 2019 at 8:13 AM Tomas Bartalos wrote: > > Hello, > > I've contributed a PR https://github.com/apache/spark/pull/23749/. I think it > is an interesting feature

PR process

2019-03-15 Thread Tomas Bartalos
Hello, I've contributed a PR https://github.com/apache/spark/pull/23749/. I think it is an interesting feature that might be of use by lot of folks from Kafka community. Our company already uses this feature for real time reporting based on Kafka events. I was trying to strictly follow the