Re: SparkLauncher#setJavaHome does not set JAVA_HOME in child process

2015-11-03 Thread gus
Thanks, Ted. The SparkLauncher test suite runs fine for me, with or without the change. Do you agree this is a bug? If so, should I open a JIRA? -- View this message in context: http://apache-spark-developers-list.1001551.n3.nabble.com/SparkLauncher-setJavaHome-does-not-set-JAVA-HOME-in-child-p

SparkLauncher#setJavaHome does not set JAVA_HOME in child process

2015-10-31 Thread gus
Hi the SparkLauncher#setJavaHome method uses its argument to find the java executable, but it does not reset the JAVA_HOME env var in the child process. As a result, spark scripts such as bin/spark-class that rely on JAVA_HOME use the wrong value. Adding this to setJavaHome fixes the problem: