Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37093759
Thanks for this fix - excellent catch !
On Sat, Mar 8, 2014 at 1:53 PM, asfgit notificati...@github.com wrote:
Closed #96
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/96
[SPARK-1194] Fix the same-RDD rule for cache replacement
SPARK-1194: https://spark-project.atlassian.net/browse/SPARK-1194
In the current implementation, when selecting candidate blocks to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-36980467
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-36980466
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10386811
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager,
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10388297
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10388411
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10390021
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37046789
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37052691
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37052692
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13049/
---
If your project
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10394468
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,18 @@ private class MemoryStore(blockManager: BlockManager,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10394826
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,18 @@ private class MemoryStore(blockManager: BlockManager,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37058765
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37064310
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37089290
@pwendell Regression test case added, also ensured that the old
implementation fails on this test case.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37089815
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37089814
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37090696
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091493
@liancheng thanks, looks great! I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091522
I decided not to merge this into 0.9... but maybe we could do that later if
there is demand for it.
---
If your project is set up for it, you can reply to this email and
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091724
May I ask the reason? I understand that impact of this bug is limited.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091891
To be clear, I merged it into master so it will be in Spark 1.0.0. I just
didn't back port it into the 0.9 branch so it won't be in Spark 0.9.1. Usually
we backport
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091921
Thanks for the explanation :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
25 matches
Mail list logo