Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10410916
--- Diff: sbin/spark-config.sh ---
@@ -34,3 +34,6 @@ this=$config_bin/$script
export SPARK_PREFIX=`dirname $this`/..
export
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10410942
--- Diff: python/Makefile ---
@@ -0,0 +1,7 @@
+assembly: clean
+ python setup.py build --build-lib build/lib
+ unzip lib/py4j*.zip -d
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10410971
--- Diff: python/pyspark/java_gateway.py ---
@@ -66,3 +71,30 @@ def run(self):
java_import(gateway.jvm, org.apache.spark.mllib.api.python.*)
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10410987
--- Diff: python/pyspark/java_gateway.py ---
@@ -66,3 +71,30 @@ def run(self):
java_import(gateway.jvm, org.apache.spark.mllib.api.python.*)
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10410991
--- Diff: python/pyspark/java_gateway.py ---
@@ -15,6 +15,7 @@
# limitations under the License.
#
+from glob import glob
--- End diff
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-37108992
I left a few minor comments in the diff, but overall this looks good to me.
It might be worth adding build/run instructions in either the PySpark
Programming
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-37109537
@sryza another thing here is, whatever the make target ends up being we
should add it to the `make_release` script and the `make-distribution` script
(those two need to
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/30#discussion_r10366986
--- Diff: python/setup.py ---
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36951182
Hey @JoshRosen mind taking a look at this I think @sryza has tested it on
YARN. But personally don't know enough about python packaging to look it over
with confidence.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36953290
Hey @sryza I tested this using a local standalone cluster and it didn't
seem to work. The executors failed when they were asked to launch pyspark:
```
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36953787
Updated to 1.0.0 and removed incubating
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36955199
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36958877
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13030/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/30#issuecomment-36226245
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
14 matches
Mail list logo
