[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10553691 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -133,11 +148,11 @@ class ClientArguments(val args:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10553724 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -133,11 +148,11 @@ class ClientArguments(val args:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10553741 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -67,24 +67,39 @@ class ClientArguments(val args:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37503046 Sandy - looks good to me. Are you still changing things? I noticed there are a few comments that maybe should be updated: ```

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10554025 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -133,11 +148,11 @@ class ClientArguments(val args:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37543156 Looks good to me. I made the small comment about perhaps leaving the --am-class out of the usage but I'm ok either way. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37563870 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37564441 Updated patch with feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37570639 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13163/ --- If your project

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37570638 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37570930 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37570929 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37577269 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37385546 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37389760 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13128/ --- If your project

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10516035 --- Diff: docs/running-on-yarn.md --- @@ -60,11 +60,11 @@ The command to launch the Spark application on the cluster is as follows: --jar

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37411628 I'm getting a compile error building this against hadoop 0.23: [ERROR] yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala:231:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37415976 I fixed the above compile error and tried to run but the executors return the following error: Unknown/unsupported param List(--num-executor, 2) Usage:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread yaoshengzhe
Github user yaoshengzhe commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10540808 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -67,24 +67,39 @@ class ClientArguments(val args:

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread yaoshengzhe
Github user yaoshengzhe commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37468388 From the code, it looks like this patch is only for renaming, is that really important to use Yarn's jargon instead of master/worker ? I think master/worker is clear

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37477894 The goal isn't to replace Spark's names with YARN's names, but rather to be consistent with the terminology used in the rest of Spark. Master refers to the service in

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37491980 Updated the patch to fix things on yarn-alpha. I verified it on a pseudo-distributed cluster with 0.23.7. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37493976 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37497424 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread sryza
GitHub user sryza opened a pull request: https://github.com/apache/spark/pull/120 SPARK-1183. Don't use worker to mean executor You can merge this pull request into a Git repository by running: $ git pull https://github.com/sryza/spark sandy-spark-1183 Alternatively you can

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37270191 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37270192 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37273006 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13110/ --- If your project

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37273004 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10486780 --- Diff: docs/running-on-yarn.md --- @@ -60,11 +60,11 @@ The command to launch the Spark application on the cluster is as follows: --jar

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10486890 --- Diff: docs/running-on-yarn.md --- @@ -60,11 +60,11 @@ The command to launch the Spark application on the cluster is as follows: --jar

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/120#discussion_r10486920 --- Diff: docs/running-on-yarn.md --- @@ -100,12 +100,12 @@ With yarn-client mode, the application will be launched locally, just like runni

[GitHub] spark pull request: SPARK-1183. Don't use worker to mean executo...

2014-03-11 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/120#issuecomment-37328825 Sandy thanks for doing this clean-up. Looks great. Just some minor comments. /cc @tgraves --- If your project is set up for it, you can reply to this email and have