Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-19 Thread Dongjoon Hyun
Thank you, Wenchen. I made the minor document-only change PR. https://github.com/apache/spark/pull/22781 Bests, Dongjoon. On Fri, Oct 19, 2018 at 6:07 PM Wenchen Fan wrote: > AFAIK we haven't tested Java 9+ yet, so I'm ok to change it. > > Hi Dongjoon can you make a PR for it? We can merge

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-19 Thread Wenchen Fan
AFAIK we haven't tested Java 9+ yet, so I'm ok to change it. Hi Dongjoon can you make a PR for it? We can merge it very soon if we decide to do it. Thanks, Wenchen On Sat, Oct 20, 2018 at 5:27 AM Dongjoon Hyun wrote: > From the document, should we be more specific with 'Java 8' instead of >

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-19 Thread Dongjoon Hyun
>From the document, should we be more specific with 'Java 8' instead of 'Java 8+' because we don't build (or test) in the community with Java 9 ~ 11. https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc3-docs/_site/building-spark.html > Building Spark using Maven requires Maven 3.3.9 or newer

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-19 Thread Koert Kuipers
i deployed 2.4.0 RC3 on our dev cluster and ran into issue with spark shell and jline. there is probably a simple workaround so this is not a serious issue but just wanted to let you know. https://issues.apache.org/jira/browse/SPARK-25783 On Mon, Oct 15, 2018 at 4:59 PM Imran Rashid wrote: > I

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-15 Thread Imran Rashid
I just discovered https://issues.apache.org/jira/browse/SPARK-25738 with some more testing. I only marked it as critical, but seems pretty bad -- I'll defer to others opinion On Sat, Oct 13, 2018 at 4:15 PM Dongjoon Hyun wrote: > Yes. From my side, it's -1 for RC3. > > Bests, > Dongjoon. > >

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-13 Thread Dongjoon Hyun
Yes. From my side, it's -1 for RC3. Bests, Dongjoon. On Sat, Oct 13, 2018 at 1:24 PM Holden Karau wrote: > So if it's a blocker would you think this should be a -1? > > On Fri, Oct 12, 2018 at 3:52 PM Dongjoon Hyun > wrote: > >> Hi, Holden. >> >> Since that's a performance at 2.4.0, I marked

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-13 Thread Holden Karau
So if it's a blocker would you think this should be a -1? On Fri, Oct 12, 2018 at 3:52 PM Dongjoon Hyun wrote: > Hi, Holden. > > Since that's a performance at 2.4.0, I marked as `Blocker` four days ago. > > Bests, > Dongjoon. > > > On Fri, Oct 12, 2018 at 11:45 AM Holden Karau > wrote: > >>

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-12 Thread Dongjoon Hyun
Hi, Holden. Since that's a performance at 2.4.0, I marked as `Blocker` four days ago. Bests, Dongjoon. On Fri, Oct 12, 2018 at 11:45 AM Holden Karau wrote: > Following up I just wanted to make sure this new blocker that Dongjoon > designated is surfaced - >

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-11 Thread Xiao Li
-1. We have two correctness bugs: https://issues.apache.org/jira/browse/SPARK-25714 and https://issues.apache.org/jira/browse/SPARK-25708. Let us fix all the three issues in ScalaUDF, as mentioned by Sean. Xiao Sean Owen 于2018年10月11日周四 上午9:04写道: > This is a legitimate question about the

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-11 Thread Sean Owen
This is a legitimate question about the behavior of ScalaUDF after the change to support 2.12: https://github.com/apache/spark/pull/22259#discussion_r224295469 Not quite a blocker I think, but a potential gotcha we definitely need to highlight in release notes. There may be an argument for

Fwd: [VOTE] SPARK 2.4.0 (RC3)

2018-10-11 Thread Wenchen Fan
Forgot to cc dev-list -- Forwarded message - From: Wenchen Fan Date: Thu, Oct 11, 2018 at 10:14 AM Subject: Re: [VOTE] SPARK 2.4.0 (RC3) To: Cc: Sean Owen Ah sorry guys, I just copy-paste the voting email from the last RC and forgot to update the date :P The voting should

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-11 Thread Hyukjin Kwon
f a majority +1 PMC > votes are cast, with > > >> a minimum of 3 +1 votes. > > > > Regards > > Surya > > > > *From:* Wenchen Fan > *Sent:* Wednesday, October 10, 2018 10:20 PM > *To:* Spark dev list > *Subject:* Re: [VOTE] SPARK

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Sean Owen
+1. I tested the source build against Scala 2.12 and common build profiles. License and sigs look OK. No blockers; one critical: SPARK-25378 ArrayData.toArray(StringType) assume UTF8String in 2.4 I think this one is "won't fix" though? not trying to restore the behavior? Other items open for

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Nicholas Chammas
FYI I believe we have an open correctness issue here: https://issues.apache.org/jira/browse/SPARK-25150 However, it needs review by another person to confirm whether it is indeed a correctness issue (and whether it still impacts this latest RC). Nick 2018년 10월 10일 (수) 오후 3:14, Jean Georges

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Jean Georges Perrin
Awesome - thanks Dongjoon! > On Oct 10, 2018, at 2:36 PM, Dongjoon Hyun wrote: > > For now, you can see generated release notes. Official one will be posted on > the website when the official 2.4.0 is out. > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315420=12342385

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Dongjoon Hyun
For now, you can see generated release notes. Official one will be posted on the website when the official 2.4.0 is out. https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315420=12342385 Bests, Dongjoon. On Wed, Oct 10, 2018 at 11:29 AM Jean Georges Perrin wrote: > Hi, > >

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Jean Georges Perrin
Hi, Sorry if it's stupid question, but where can I find the release notes of 2.4.0? jg > On Oct 10, 2018, at 2:00 PM, Imran Rashid > wrote: > > Sorry I had messed up my testing earlier, so I only just discovered >

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Imran Rashid
Sorry I had messed up my testing earlier, so I only just discovered https://issues.apache.org/jira/browse/SPARK-25704 I dont' think this is a release blocker, because its not a regression and there is a workaround, just fyi. On Wed, Oct 10, 2018 at 11:47 AM Wenchen Fan wrote: > Please vote on

RE: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Garlapati, Suryanarayana (Nokia - IN/Bangalore)
dev list Subject: Re: [VOTE] SPARK 2.4.0 (RC3) I'm adding my own +1, since there are no known blocker issues. The correctness issue has been fixed, the streaming Java API problem has been resolved, and we have upgraded to Scala 2.12.7. On Thu, Oct 11, 2018 at 12:46 AM Wenchen Fan mailto:c

Re: [VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Wenchen Fan
I'm adding my own +1, since there are no known blocker issues. The correctness issue has been fixed, the streaming Java API problem has been resolved, and we have upgraded to Scala 2.12.7. On Thu, Oct 11, 2018 at 12:46 AM Wenchen Fan wrote: > Please vote on releasing the following candidate as

[VOTE] SPARK 2.4.0 (RC3)

2018-10-10 Thread Wenchen Fan
Please vote on releasing the following candidate as Apache Spark version 2.4.0. The vote is open until October 1 PST and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. [ ] +1 Release this package as Apache Spark 2.4.0 [ ] -1 Do not release this package because ... To