Expression.resolved unmatched with the correct values in catalyst?

2015-07-15 Thread Takeshi Yamamuro
Hi, devs I found that the case of 'Expression.resolved != (Expression.childrenResolved && checkInputDataTypes().isSuccess)' occurs in the output of Analyzer. That is, some tests in o.a.s.sql.* fail if the codes below are added in CheckAnalysis: https://github.com/maropu/spark/commit/a488eee8351f5

Re: Expression.resolved unmatched with the correct values in catalyst?

2015-07-18 Thread Ted Yu
What if you move your addition to before line 64 (in master branch there is case for if e.checkInputDataTypes().isFailure): case c: Cast if !c.resolved => Cheers On Wed, Jul 15, 2015 at 12:47 AM, Takeshi Yamamuro wrote: > Hi, devs > > I found that the case of 'Expression.resolved !=

Re: Expression.resolved unmatched with the correct values in catalyst?

2015-07-22 Thread Takeshi Yamamuro
The move prevents some errors though, all the errors cannot be gone. For example, in o.a.s.sql.catalyst.analysis.*Suite, The case ' https://github.com/maropu/spark/commit/961b5e99e2136167f175598ed36585987cc1e236 ' causes 3 errors. AnalysisSuite: - analyze project *** FAILED *** AnalysisErrorSuite:

Re: Expression.resolved unmatched with the correct values in catalyst?

2015-07-22 Thread Takeshi Yamamuro
Ok, thanks, I understood why this happened. best regards, // maropu On Wed, Jul 22, 2015 at 10:26 PM, Takeshi Yamamuro wrote: > The move prevents some errors though, all the errors cannot be gone. > For example, in o.a.s.sql.catalyst.analysis.*Suite, > > The case ' > https://github.com/maropu/