Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
[adding dev] On Wed, Nov 4, 2015 at 2:27 PM, Fazlan Nazeem wrote: > I just went through all specifications, and they expect the version > attribute. This should be addressed very soon because if we cannot use the > PMML model without the version attribute, there is no use of generating one > wit

Re: PMML version in MLLib

2015-11-04 Thread Sean Owen
I'm pretty sure that attribute is required. I am not sure what PMML version the code has been written for but would assume 4.2.1. Feel free to open a PR to add this version to all the output. On Wed, Nov 4, 2015 at 11:42 AM, Fazlan Nazeem wrote: > [adding dev] > > On Wed, Nov 4, 2015 at 2:27 PM,

Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
Thanks Owen. Will do it On Wed, Nov 4, 2015 at 5:22 PM, Sean Owen wrote: > I'm pretty sure that attribute is required. I am not sure what PMML > version the code has been written for but would assume 4.2.1. Feel > free to open a PR to add this version to all the output. > > On Wed, Nov 4, 2015 a

Re: PMML version in MLLib

2015-11-08 Thread Vincenzo Selvaggio
Hi, I confirm the models are exported for PMML version 4.2, in fact you can see in the generated xml PMML xmlns="http://www.dmg.org/PMML-4_2"; This is the default version when using https://github.com/jpmml/jpmml-model/tree/1.1.X. I didn't realize the attribute version of the PMML root element wa

Re: PMML version in MLLib

2015-11-08 Thread Fazlan Nazeem
Hi Vincenzo/Owen, I have sent a pull request[1] with necessary changes to add the pmml version attribute to the root node. I have also linked the issue under the PMML improvement umbrella[2] as you suggested. [1] https://github.com/apache/spark/pull/9558 [2] https://issues.apache.org/jira/browse

Re: PMML version in MLLib

2015-11-10 Thread selvinsource
Thank you Fazlan, looks good! -- View this message in context: http://apache-spark-developers-list.1001551.n3.nabble.com/Re-PMML-version-in-MLLib-tp14944p15112.html Sent from the Apache Spark Developers List mailing list archive at Nabble.com